SDN 2316: Use GatewayConfig in OVN-K to set gateway modes

[tssurya]

Depends On openshift/api#1033 and #1242

In this PR, we are doing two things:

• Removing the exclusiveness between EgressIPs and ICNI
• Removing the hidden config-map and using the new api routingViaHost to configure gateway modes.

We also handle the upgrade logic of populating the new API field in the cluster CRD based on the gateway-mode-config map values. Also note that this enables users to migrate between the two gateway modes at runtime.

[tssurya]

I have tested this PR against a cluster and it works as expected.

spec:
  clusterNetwork:
  - cidr: 10.128.0.0/14
    hostPrefix: 23
  defaultNetwork:
    ovnKubernetesConfig:
      gatewayConfig:
        routingViaHost: true
      genevePort: 6081
      mtu: 8901
      policyAuditConfig:
        destination: "null"
        maxFileSize: 50
        rateLimit: 20
        syslogFacility: local0
    type: OVNKubernetes

It rolls out local gateway as soon as we change the gatewayConfig and add the routingViaHost config parameter.

[tssurya]

/test e2e-agnostic-upgrade
/test e2e-gcp-ovn-upgrade

[tssurya]

/hold

[tssurya]

/hold cancel

[tssurya]

/retest

[tssurya]

/assign @trozet @astoycos : PTAL

[openshift-ci]

@tssurya: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-vsphere-ovn	5ee9f36	link	false	/test e2e-vsphere-ovn
ci/prow/e2e-ovn-hybrid-step-registry	5ee9f36	link	false	/test e2e-ovn-hybrid-step-registry

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[tssurya]

/retest-required

[trozet]

This doesn't actually update the config map right? Do we need to update the config map from here so that when we remove the ability to use the hidden configmap we dont break users? Or should we print some warning or event to tell the user they need to update the gatewayConfig in their configmap?

[tssurya]

We do update the configmap when this function returns. Let me explain:

1. cluster-network-operator/pkg/network/bootstrap.go

   Line 18 in 38b07c3

   case operv1.NetworkTypeOVNKubernetes:

2. cluster-network-operator/pkg/network/ovn_kubernetes.go

   Line 485 in 38b07c3

   func bootstrapOVN(conf *operv1.Network, kubeClient client.Client) (*bootstrap.BootstrapResult, error) {

3. cluster-network-operator/pkg/network/ovn_kubernetes.go

   Line 284 in 38b07c3

   func bootstrapOVNConfig(kubeClient client.Client) (*bootstrap.OVNConfigBoostrapResult, error) {

4. Within bootstrapOVNConfig we do our thing.
5. Then we return all the way back to the bootstrap call

   cluster-network-operator/pkg/controller/operconfig/operconfig_controller.go

   Line 192 in 38b07c3

   bootstrapResult, err := network.Bootstrap(newOperConfig, r.client)

6. Aaaand this is where we update the CRD:

   cluster-network-operator/pkg/controller/operconfig/operconfig_controller.go

   Lines 200 to 201 in 38b07c3

   	if !reflect.DeepEqual(operConfig, newOperConfig) {
   	if err := r.UpdateOperConfig(newOperConfig); err != nil {

Hence any changes done to the CRD during bootstrap gets written into the CRD. After all that the rendering starts and it regards the updated CRD the source of truth.

I tested it using the steps mentioned in https://docs.google.com/document/d/1SYaNQNW4sWVTE9XgHG6gKsS4ZActK8_Z7wILXU5YuoU/edit#heading=h.d5s838mpuww0 in a cluster-bot cluster and it works well. The CRD does get updated to something like:

Gateway Config:{
    Routing Via Host: true
}

[tssurya]

/test e2e-gcp-ovn-upgrade

[trozet]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: trozet, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [trozet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment