[release-4.14] OCPBUGS-11550: AUTH: update cluster-reader to include k8s.ovn.org

[flavio-fernandes]

API group "k8s.ovn.org" should be included to cluster-reader role. That group has the following resources:
- EgressFirewall
- EgressIP
- EgressQoS

[openshift-ci-robot]

@flavio-fernandes: This pull request references Jira Issue OCPBUGS-11550, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

API group "k8s.ovn.org" should be included to cluster-reader role. That group has the following resources:

• EgressFirewall
• EgressIP
• EgressQoS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@flavio-fernandes: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-network-mtu-migration-ovn-ipv4	7f2f900	link	false	/test e2e-network-mtu-migration-ovn-ipv4
ci/prow/e2e-gcp-ovn-upgrade	7f2f900	link	false	/test e2e-gcp-ovn-upgrade
ci/prow/e2e-openstack-ovn	7f2f900	link	false	/test e2e-openstack-ovn
ci/prow/e2e-vsphere-ovn	7f2f900	link	false	/test e2e-vsphere-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[flavio-fernandes]

Verified this change by deploying OCP with the new cluster role:

vagrant@devmaster ~/dev/openshift-apiserver.git OCPBUGS-11550_k8s.ovn.org*
❯ oc auth can-i list egressfirewalls --as=test --as-group=mylocaladmins
no

❯ oc --user=admin create secret generic htpasswd --from-file=htpasswd -n openshift-config
secret/htpasswd created

❯ oc replace -f - <<API
apiVersion: config.openshift.io/v1
kind: OAuth
metadata:
  name: cluster
spec:
  identityProviders:
  - name: Local Password
    mappingMethod: claim
    type: HTPasswd
    htpasswd:
      fileData:
        name: htpasswd
API
oauth.config.openshift.io/cluster replaced

❯ oc adm groups new mylocaladmins
group.user.openshift.io/mylocaladmins created

❯ oc adm groups add-users mylocaladmins test
group.user.openshift.io/mylocaladmins added: "test"

❯ oc adm policy add-cluster-role-to-group cluster-reader mylocaladmins
clusterrole.rbac.authorization.k8s.io/cluster-reader added: "mylocaladmins"

❯ oc auth can-i create pods --as=test --as-group=mylocaladmins
no

❯ oc auth can-i list pods --as=test --as-group=mylocaladmins
yes

❯ oc auth can-i list egressips --as=test --as-group=mylocaladmins
Warning: resource 'egressips' is not namespace scoped in group 'k8s.ovn.org'

yes

❯ oc auth can-i list egressfirewalls --as=test --as-group=mylocaladmins
yes

❯ oc auth can-i create egressfirewalls --as=test --as-group=mylocaladmins
no

❯ oc describe ClusterRole openshift-ovn-kubernetes-cluster-reader
Name:         openshift-ovn-kubernetes-cluster-reader
Labels:       rbac.authorization.k8s.io/aggregate-to-cluster-reader=true
Annotations:  <none>
PolicyRule:
  Resources                    Non-Resource URLs  Resource Names  Verbs
  ---------                    -----------------  --------------  -----
  egressfirewalls.k8s.ovn.org  []                 []              [get list watch]
  egressips.k8s.ovn.org        []                 []              [get list watch]
  egressqoses.k8s.ovn.org      []                 []              [get list watch]

❯ oc get ClusterRole cluster-reader -oyaml | grep -B1 -A9 ovn
- apiGroups:
  - k8s.ovn.org
  resources:
  - egressfirewalls
  - egressips
  - egressqoses
  verbs:
  - get
  - list
  - watch
- apiGroups:

[flavio-fernandes]

Some cool references on the aggregation support:

• https://kubernetes.io/docs/reference/access-authn-authz/rbac/#:~:text=Aggregated%20ClusterRoles,-You%20can%20aggregate%20several%20ClusterRoles
• ClusterRole Aggregation kubernetes/enhancements#502
• aggregate cluster roles kubernetes/kubernetes#54005

[flavio-fernandes]

@kyrtapz PTAL

[flavio-fernandes]

Original change was done at the wrong (not as good) place:
openshift/openshift-apiserver#363

[kyrtapz]

/lgtm

[trozet]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flavio-fernandes, kyrtapz, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [trozet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD ddb4322 and 2 for PR HEAD 7f2f900 in total

[openshift-ci-robot]

@flavio-fernandes: Jira Issue OCPBUGS-11550: All pull requests linked via external trackers have merged:

• openshift/cluster-network-operator#1791

Jira Issue OCPBUGS-11550 has been moved to the MODIFIED state.

In response to this:

API group "k8s.ovn.org" should be included to cluster-reader role. That group has the following resources:

• EgressFirewall
• EgressIP
• EgressQoS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[flavio-fernandes]

/cherry-pick release-4.13

[openshift-cherrypick-robot]

@flavio-fernandes: new pull request created: #1797

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.