Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leader.go: remove unused file #441

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

jmencak
Copy link
Contributor

@jmencak jmencak commented Aug 22, 2022

leader.go file is no longer used. During refactoring/PAO merge, PR316 forgot to remove it. Do it now.

leader.go file is no longer used.  During refactoring/PAO merge,
PR316 forgot to remove it.  Do it now.
@openshift-ci openshift-ci bot requested review from ffromani and MarSik August 22, 2022 11:44
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 22, 2022

@jmencak: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jmencak
Copy link
Contributor Author

jmencak commented Aug 22, 2022

/assign @dagrayvid

@dagrayvid
Copy link
Contributor

/lgtm

Thanks.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2022
@openshift-merge-robot openshift-merge-robot merged commit 06183ac into openshift:master Aug 22, 2022
@jmencak jmencak deleted the 4.12-remove-leader branch August 22, 2022 15:54
IlyaTyomkin pushed a commit to IlyaTyomkin/cluster-node-tuning-operator that referenced this pull request May 23, 2023
leader.go file is no longer used.  During refactoring/PAO merge,
PR316 forgot to remove it.  Do it now.

Co-authored-by: Jiri Mencak <jmencak@users.noreply.github.com>
IlyaTyomkin pushed a commit to IlyaTyomkin/cluster-node-tuning-operator that referenced this pull request Jun 13, 2023
leader.go file is no longer used.  During refactoring/PAO merge,
PR316 forgot to remove it.  Do it now.

Co-authored-by: Jiri Mencak <jmencak@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants