-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SO-119: Fix mariadb import url in OKD #525
SO-119: Fix mariadb import url in OKD #525
Conversation
Maria DB is a Non S2i Samples and OKD . we have already done the release sync for 4.15 and wont merge this PR in Samples Operater. |
Samples Operator will have to be fixed, as this invalid url breaks OKD build testing. |
This was communicated way before that changes wouldn't be accepted starting ocp 4.15, i hope there is a plan in place for future to decouple this from Samples operator as we are going to remove the assests folder itself We are Downsizing CSO. May be even if i merge it this time, the release process is already done for samples side if that is not your concern i can try checking about this |
This change does not concern OCP. It concerns OKD. Both are built from the same codebase, but the manifest changed here is OKD-only. This is critical to fix builds here: https://origin-release.ci.openshift.org/#4.15.0-0.okd-scos |
/retest-required |
/retitle SO-119: Fix mariadb import url in OKD |
@LorbusChris: This pull request references SO-119 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test okd-scos-e2e-aws-ovn |
1 similar comment
/test okd-scos-e2e-aws-ovn |
/test okd-e2e-aws-ovn |
@LorbusChris: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@fbm3307 tests are passing, could you take a look again? This is critical to get the OKD integration stream builds fixed on master. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fbm3307, LorbusChris The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
aa379b2
into
openshift:master
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cluster-samples-operator-container-v4.16.0-202312061931.p0.gaa379b2.assembly.stream for distgit ose-cluster-samples-operator. |
OKD tests are currently broken due to imagestream samples introduced in the recent sync containing invalid image import URLs.
This PR contains changes from: