-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-41111: vendor: Update openshift/api to pick up v4.17 and v4.18 capability sets #1086
OCPBUGS-41111: vendor: Update openshift/api to pick up v4.17 and v4.18 capability sets #1086
Conversation
Catching up with [1]. Generated with: $ go get github.com/openshift/api@master $ go mod tidy $ go mod vendor $ git add -A go.* vendor all using: $ go version go version go1.22.2 linux/amd64 [1]: openshift/api#2022
@wking: This pull request references Jira Issue OCPBUGS-41111, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@wking: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sanity check on e2e-agnostic-ovn looks good: $ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_cluster-version-operator/1086/pull-ci-openshift-cluster-version-operator-master-e2e-agnostic-ovn/1833977761480314880/artifacts/e2e-agnostic-ovn/gather-must-gather/artifacts/must-gather.tar | tar -tvz | grep clusterversions.config.openshift.io
-rw------- 1008580000/root 41631 2024-09-11 16:25 registry-build09-ci-openshift-org-ci-op-4vc3b9hy-stable-sha256-6cb3640e26d5cb9e0cced9e90dd86f06313d9a2ca8389b770541b820d2b758f1/cluster-scoped-resources/apiextensions.k8s.io/customresourcedefinitions/clusterversions.config.openshift.io.yaml
$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_cluster-version-operator/1086/pull-ci-openshift-cluster-version-operator-master-e2e-agnostic-ovn/1833977761480314880/artifacts/e2e-agnostic-ovn/gather-must-gather/artifacts/must-gather.tar | tar -xOz registry-build09-ci-openshift-org-ci-op-4vc3b9hy-stable-sha256-6cb3640e26d5cb9e0cced9e90dd86f06313d9a2ca8389b770541b820d2b758f1/cluster-scoped-resources/apiextensions.k8s.io/customresourcedefinitions/clusterversions.config.openshift.io.yaml | grep -A3 v4.16
- v4.16
- v4.17
- v4.18
- vCurrent We'll need a vendor bump in the installer too, to get the install-config validation accepting the new sets, but we'll want that to land after this change (or the installer might accept a set in the install-config that the API wouldn't allow into ClusterVersion). |
pre-merge verify pass /label qe-approved |
@wking: This pull request references Jira Issue OCPBUGS-41111, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: petr-muller, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[ART PR BUILD NOTIFIER] Distgit: cluster-version-operator |
Catching up with [1], and a backport-ish of 6abe8bb (vendor: Update openshift/api to pick up v4.17 and v4.18 capability sets, 2024-09-11, openshift#1086). Generated with: $ GOPROXY=direct go get github.com/openshift/api@release-4.17 $ go mod tidy $ go mod vendor $ git add -A go.* vendor all using: $ go version go version go1.22.2 linux/amd64 where GOPROXY=direct avoids a caching delay [2]: I committed a new change (or released a new version) to a repository, why isn't it showing up when I run go get -u or go list -m --versions? In order to improve our services' caching and serving latencies, new versions may not show up right away. If you want new code to be immediately available in the mirror, then first make sure there is a semantically versioned tag for this revision in the underlying source repository. Then explicitly request that version via go get module@version. The new version should be available within one minute. Note that if someone requested the version before the tag was pushed, it may take up to 30 minutes for the mirror's cache to expire and fresh data about the version to become available. If the version is still not available after 30 minutes, please file an issue. [1]: openshift/api#2023 [2]: https://proxy.golang.org/
Catching up with openshift/api#2022. Generated with:
all using: