Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/cvo/status: Fix "syncDegradedStatus" -> "syncFailingStatus" comment #355

Merged
merged 1 commit into from
Jun 1, 2020
Merged

pkg/cvo/status: Fix "syncDegradedStatus" -> "syncFailingStatus" comment #355

merged 1 commit into from
Jun 1, 2020

Conversation

wking
Copy link
Member

@wking wking commented Apr 21, 2020

This slipped through in 7c52414 (#47).

@wking
pkg/cvo/status: Fix "syncDegradedStatus" -> "syncFailingStatus" comment
2884447 
This slipped through in 7c52414 (cvo: Report errors to conditions
more consistently, 2018-11-02, openshift#47).
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 21, 2020
vrutkovs
vrutkovs approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@vrutkovs vrutkovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrutkovs, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@LalatenduMohanty
Copy link
Member

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@sdodson
Copy link
Member

sdodson commented Jun 1, 2020

/override ci/prow/e2e-aws

@openshift-ci-robot
Copy link
Contributor

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-aws

In response to this:

/override ci/prow/e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 7cb7909 into openshift:master Jun 1, 2020
@wking wking deleted the syncDegradedStatus-typo branch June 1, 2020 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrutkovs vrutkovs vrutkovs approved these changes

@sdodson sdodson Awaiting requested review from sdodson

Assignees

@vrutkovs vrutkovs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@wking @openshift-ci-robot @LalatenduMohanty @openshift-bot @sdodson @vrutkovs @openshift-merge-robot