Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for a 1.0.0 release, plus release redhat.openshift to Automation Hub #51

Closed
geerlingguy opened this issue Nov 12, 2020 · 5 comments

Comments

@geerlingguy
Copy link
Contributor

SUMMARY

We are going to tag 0.3.0 as 1.0.0 and release it to Automation Hub as well, but as redhat.openshift.

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

Releases

ADDITIONAL INFORMATION

N/A

geerlingguy added a commit to geerlingguy/community.okd that referenced this issue Nov 12, 2020
@tima
Copy link
Contributor

tima commented Nov 12, 2020

/lgtm

@geerlingguy
Copy link
Contributor Author

Related: #53. (That's the current blocker.)

@geerlingguy
Copy link
Contributor Author

One other issue was found after running make downstream-build and uploading to Automation Hub:

Error running ansible-doc: cmd="/usr/bin/env ANSIBLE_COLLECTIONS_PATHS=/tmp/tmp58gaersy ansible-doc --type module --json redhat.openshift.openshift_route redhat.openshift.openshift_auth redhat.openshift.k8s redhat.openshift.k8s_auth redhat.openshift.openshift_process" returncode="1" b"[WARNING]: Failed to create the directory '/.ansible': [Errno 13] Permission\ndenied: b'/.ansible'\nERROR! module redhat.openshift.openshift_route missing documentation (or could not parse documentation): unknown doc_fragment(s) in file /tmp/tmp58gaersy/ansible_collections/redhat/openshift/plugins/modules/openshift_route.py: kubernetes.core.k8s_auth_options, kubernetes.core.k8s_wait_options, kubernetes.core.k8s_state_options\n" 

@geerlingguy
Copy link
Contributor Author

Also found some other errors later in the import process:

ERROR: Found 1 shebang issue(s) which need to be resolved: 
ERROR: ci/incluster_integration.sh:1:1: unexpected non-module shebang: b'#!/bin/bash' 
See documentation for help: https://docs.ansible.com/ansible/2.9/dev_guide/testing/sanity/shebang.html 
Running sanity test 'shellcheck' 
ERROR: Found 8 shellcheck issue(s) which need to be resolved: 
ERROR: ci/downstream.sh:35:21: SC2068: Double quote array expansions to avoid re-splitting elements. 
ERROR: ci/incluster_integration.sh:14:1: SC2034: component appears unused. Verify it or export it. 
ERROR: ci/incluster_integration.sh:15:12: SC2086: Double quote to prevent globbing and word splitting. 
ERROR: ci/incluster_integration.sh:19:23: SC2086: Double quote to prevent globbing and word splitting. 
ERROR: ci/incluster_integration.sh:21:23: SC2086: Double quote to prevent globbing and word splitting. 
ERROR: ci/incluster_integration.sh:24:12: SC2086: Double quote to prevent globbing and word splitting. 
ERROR: ci/incluster_integration.sh:55:82: SC2086: Double quote to prevent globbing and word splitting. 
ERROR: ci/incluster_integration.sh:63:80: SC2086: Double quote to prevent globbing and word splitting. 
See documentation for help: https://docs.ansible.com/ansible/2.9/dev_guide/testing/sanity/shellcheck.html 

@geerlingguy
Copy link
Contributor Author

The 1.0.0 release is up on Galaxy, and I just uploaded it to Automation Hub as redhat.openshift.

Please note that I ran into a few validation errors (though functionality seems unaffected) after the import—I opened a follow-up issue, #57, to address those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants