add downstream build scripts #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Miller <admiller@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maxamillion The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Signed-off-by: Adam Miller <admiller@redhat.com>
Signed-off-by: Adam Miller <admiller@redhat.com>
Signed-off-by: Adam Miller <admiller@redhat.com>
Signed-off-by: Adam Miller <admiller@redhat.com>
Signed-off-by: Adam Miller <admiller@redhat.com>
Signed-off-by: Adam Miller <admiller@redhat.com>
…and GA Signed-off-by: Adam Miller <admiller@redhat.com>
fabianvf
reviewed
Sep 2, 2020
| f_install_kubernetes_core_from_src | ||
| pushd "${_build_dir}" || return | ||
| f_log_info "INTEGRATION TEST WD: ${PWD}" | ||
| make test-integration-incluster |
There was a problem hiding this comment.
This will end up calling make test-integration in the image built from CI/Dockerfile, will that end up running anything from the downstream steps?
Signed-off-by: Adam Miller <admiller@redhat.com>
|
recheck |
|
/retry |
|
/retest |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Adam Miller admiller@redhat.com
SUMMARY
add downstream build script, additions to Makefile, and a new CI job to run the downstream sanity tests
ISSUE TYPE
COMPONENT NAME
Makefile