Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #57: Switch dependency from community.kubernetes to kubernetes.core. #58

Merged
merged 3 commits into from
Nov 16, 2020

Conversation

geerlingguy
Copy link
Contributor

See #57.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2020
@geerlingguy
Copy link
Contributor Author

geerlingguy commented Nov 13, 2020

Well, at least I'm able to reproduce the error that we're getting in AH now:

ERROR: Command "ansible-doc -t module community.okd.k8s community.okd.openshift_auth community.okd.openshift_process community.okd.openshift_route" returned exit status 1.
>>> Standard Error
ERROR! module community.okd.k8s missing documentation (or could not parse documentation): unknown doc_fragment(s) in file /root/ansible/ansible_collections/community/okd/plugins/modules/k8s.py: kubernetes.core.k8s_state_options, kubernetes.core.k8s_name_options, kubernetes.core.k8s_resource_options, kubernetes.core.k8s_auth_options

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geerlingguy, maxamillion

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [geerlingguy,maxamillion]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2020
@geerlingguy
Copy link
Contributor Author

I think the last thing I need to do to get this passing is to manually install the collection requirement (kubernetes.core) with Galaxy for the Sanity test checks.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2020
@openshift-merge-robot
Copy link

openshift-merge-robot commented Nov 16, 2020

@geerlingguy: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/integration 36a27e8 link /test integration

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@maxamillion
Copy link
Member

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants