Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Quay compliance-operator/compliance-operator-content for content … #821

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,10 @@ Versioning](https://semver.org/spec/v2.0.0.html).

### Fixes

-
- The compliance content images have moved to
[compliance-operator/compliance-operator-content](https://quay.io/repository/compliance-operator/compliance-operator-content)
Quay repository. This should be a transparent change for end users and fixes
CI that relies on content for end-to-end testing.

### Internal Changes

Expand Down
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,8 @@ E2E_SKIP_CONTAINER_BUILD?=false
E2E_GO_TEST_FLAGS?=-test.v -test.timeout 120m

# Specifies the image path to use for the content in the tests
DEFAULT_CONTENT_IMAGE_PATH=quay.io/complianceascode/ocp4:latest
E2E_CONTENT_IMAGE_PATH?=quay.io/complianceascode/ocp4:latest
DEFAULT_CONTENT_IMAGE_PATH=quay.io/compliance-operator/compliance-operator-content:latest
E2E_CONTENT_IMAGE_PATH?=quay.io/compliance-operator/compliance-operator-content:latest
# We specifically omit the tag here since we use this for testing
# different images referenced by different tags.
E2E_BROKEN_CONTENT_IMAGE_PATH?=quay.io/compliance-operator/test-broken-content
Expand Down
2 changes: 1 addition & 1 deletion deploy/compliance-operator-chart/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ spec:
- name: RELATED_IMAGE_OPERATOR
value: "quay.io/compliance-operator/compliance-operator:latest"
- name: RELATED_IMAGE_PROFILE
value: "quay.io/complianceascode/ocp4:latest"
value: "quay.io/compliance-operator/compliance-operator-content:latest"
volumeMounts:
- name: serving-cert
mountPath: /var/run/secrets/serving-cert
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@ spec:
- name: workers-scan
profile: xccdf_org.ssgproject.content_profile_moderate
content: ssg-rhcos4-ds.xml
contentImage: quay.io/complianceascode/ocp4:latest
contentImage: quay.io/compliance-operator/compliance-operator-content:latest
nodeSelector:
node-role.kubernetes.io/worker: ""
- name: platform-scan
scanType: Platform
profile: xccdf_org.ssgproject.content_profile_moderate
content: ssg-ocp4-ds.xml
contentImage: quay.io/complianceascode/ocp4:latest
contentImage: quay.io/compliance-operator/compliance-operator-content:latest
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@ kind: ProfileBundle
metadata:
name: ocp4
spec:
contentImage: quay.io/complianceascode/ocp4:latest
contentImage: quay.io/compliance-operator/compliance-operator-content:latest
contentFile: ssg-ocp4-ds.xml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ metadata:
"scans": [
{
"content": "ssg-rhcos4-ds.xml",
"contentImage": "quay.io/complianceascode/ocp4:latest",
"contentImage": "quay.io/compliance-operator/compliance-operator-content:latest",
"name": "workers-scan",
"nodeSelector": {
"node-role.kubernetes.io/worker": ""
Expand All @@ -47,7 +47,7 @@ metadata:
},
{
"content": "ssg-ocp4-ds.xml",
"contentImage": "quay.io/complianceascode/ocp4:latest",
"contentImage": "quay.io/compliance-operator/compliance-operator-content:latest",
"name": "platform-scan",
"profile": "xccdf_org.ssgproject.content_profile_moderate",
"scanType": "Platform"
Expand All @@ -64,7 +64,7 @@ metadata:
},
"spec": {
"contentFile": "ssg-ocp4-ds.xml",
"contentImage": "quay.io/complianceascode/ocp4:latest"
"contentImage": "quay.io/compliance-operator/compliance-operator-content:latest"
}
},
{
Expand Down Expand Up @@ -1291,7 +1291,7 @@ spec:
- name: RELATED_IMAGE_OPERATOR
value: quay.io/compliance-operator/compliance-operator:0.1.49
- name: RELATED_IMAGE_PROFILE
value: quay.io/complianceascode/ocp4:latest
value: quay.io/compliance-operator/compliance-operator-content:latest
image: quay.io/compliance-operator/compliance-operator:0.1.49
imagePullPolicy: Always
name: compliance-operator
Expand Down
2 changes: 1 addition & 1 deletion deploy/operator.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ spec:
- name: RELATED_IMAGE_OPERATOR
value: "quay.io/compliance-operator/compliance-operator:latest"
- name: RELATED_IMAGE_PROFILE
value: "quay.io/complianceascode/ocp4:latest"
value: "quay.io/compliance-operator/compliance-operator-content:latest"
volumeMounts:
- name: serving-cert
mountPath: /var/run/secrets/serving-cert
Expand Down
8 changes: 4 additions & 4 deletions doc/crds.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ An example `ProfileBundle` object looks like this:
namespace: openshift-compliance
spec:
contentFile: ssg-ocp4-ds.xml
contentImage: quay.io/complianceascode/ocp4:latest
contentImage: quay.io/compliance-operator/compliance-operator-content:latest
status:
dataStreamStatus: VALID
```
Expand All @@ -57,7 +57,7 @@ Where:
* **status.errorMessage**: In case parsing of the content files fails, this
attribute will contain a human-readable explanation.

The ComplianceAsCode upstream image is located at `quay.io/complianceascode/ocp4:latest`.
The ComplianceAsCode upstream image is located at `quay.io/compliance-operator/compliance-operator-content:latest`.
For OCP4, the two most used `contentFile` values would be `ssg-ocp4-ds.xml` which contain
the platform (Kubernetes) checks and `ssg-rhcos4-ds.xml` file which contains the node
(OS level) checks. For these two files, the corresponding `ProfileBundle` objects are created
Expand Down Expand Up @@ -474,7 +474,7 @@ spec:
scanType: Node
profile: xccdf_org.ssgproject.content_profile_moderate
content: ssg-rhcos4-ds.xml
contentImage: quay.io/complianceascode/ocp4:latest
contentImage: quay.io/compliance-operator/compliance-operator-content:latest
rule: "xccdf_org.ssgproject.content_rule_no_netrc_files"
nodeSelector:
node-role.kubernetes.io/worker: ""
Expand Down Expand Up @@ -545,7 +545,7 @@ spec:
scanType: Node
profile: xccdf_org.ssgproject.content_profile_moderate
content: ssg-ocp4-ds.xml
contentImage: quay.io/complianceascode/ocp4:latest
contentImage: quay.io/compliance-operator/compliance-operator-content:latest
rule: "xccdf_org.ssgproject.content_rule_no_netrc_files"
nodeSelector:
node-role.kubernetes.io/worker: ""
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,12 @@ usability:
product where product might be `ocp4` or `rhcos4`.

By default, the Compliance Operator creates two `profilebundle` objects, one for
OCP and one for RHCOS based on the [upstream ComplianceAsCode content images](https://quay.io/repository/complianceascode/ocp4):
OCP and one for RHCOS based on the [upstream ComplianceAsCode content images](https://quay.io/repository/compliance-operator/compliance-operator-content):
```
$ oc get profilebundle.compliance
NAME CONTENTIMAGE CONTENTFILE STATUS
ocp4 quay.io/complianceascode/ocp4:latest ssg-ocp4-ds.xml VALID
rhcos4 quay.io/complianceascode/ocp4:latest ssg-rhcos4-ds.xml VALID
ocp4 quay.io/compliance-operator/compliance-operator-content:latest ssg-ocp4-ds.xml VALID
rhcos4 quay.io/compliance-operator/compliance-operator-content:latest ssg-rhcos4-ds.xml VALID
```

Inspecting the ProfileBundle objects, you'll see that they mostly point to the
Expand All @@ -56,7 +56,7 @@ metadata:
uid: f5516313-5f16-4ff8-9c69-d79d44126b8b
spec:
contentFile: ssg-rhcos4-ds.xml
contentImage: quay.io/complianceascode/ocp4:latest
contentImage: quay.io/compliance-operator/compliance-operator-content:latest
status:
dataStreamStatus: VALID
```
Expand Down
2 changes: 1 addition & 1 deletion images/testcontent/Dockerfile.ci
Original file line number Diff line number Diff line change
@@ -1 +1 @@
FROM quay.io/complianceascode/ocp4:latest
FROM quay.io/compliance-operator/compliance-operator-content:latest
2 changes: 1 addition & 1 deletion pkg/controller/compliancescan/utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import (
)

const (
DefaultContentContainerImage = "quay.io/complianceascode/ocp4:latest"
DefaultContentContainerImage = "quay.io/compliance-operator/compliance-operator-content:latest"
CACertDataKey = "ca.crt"
CAKeyDataKey = "ca.key"
ServerCertInstanceSuffix = "-rs"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ var _ = Describe("Testing scansettingbinding controller", func() {
Namespace: common.GetComplianceOperatorNamespace(),
},
Spec: compv1alpha1.ProfileBundleSpec{
ContentImage: "quay.io/complianceascode/ocp4:latest",
ContentImage: "quay.io/compliance-operator/compliance-operator-content:latest",
ContentFile: "ssg-rhcos4-ds.xml",
},
Status: compv1alpha1.ProfileBundleStatus{
Expand Down
2 changes: 1 addition & 1 deletion pkg/utils/images.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ var componentDefaults = []struct {
}{
{"quay.io/compliance-operator/openscap-ocp:1.3.3", "RELATED_IMAGE_OPENSCAP"},
{"quay.io/compliance-operator/compliance-operator:latest", "RELATED_IMAGE_OPERATOR"},
{"quay.io/complianceascode/ocp4:latest", "RELATED_IMAGE_PROFILE"},
{"quay.io/compliance-operator/compliance-operator-content:latest", "RELATED_IMAGE_PROFILE"},
}

// GetComponentImage returns a full image pull spec for a given component
Expand Down