Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(OSD-19388): use backplane and enable new flow #248

Merged
merged 5 commits into from
Nov 27, 2023

Conversation

typeid
Copy link
Member

@typeid typeid commented Nov 24, 2023

What?

  • Moves CAD to use backplane for the old flow
  • Enables CAD to get cloud credentials through the new flow (also via backplane)

Cleanup:

  • Renames v1 to cmv1

Why?
https://issues.redhat.com/browse/OSD-19388

Notes: this PR is waiting for openshift/backplane-cli#267 which adds logic to allow CAD to re-use backplane-cli's bpcloud.GetAWSV2Config logic.

Tests:
Tested the following scenarios locally:

  • changed trust policy to not allow jump, results in CAD setting LS
  • delete installer role, results in CAD setting LS
  • delete installer and support role, results in CAD setting LS
  • delete just support role: results in CAD setting LS
  • pure OCM errors don't result in LS
  • Full CAD CHGM run of the new and old flow.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 24, 2023
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 24, 2023
)

replace (
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For testing with the local backplane-cli build. This will be changed to the backplane-cli version once openshift/backplane-cli#267 merges.

@RaphaelBut
Copy link
Contributor

looks good to me 👍

@typeid
Copy link
Member Author

typeid commented Nov 27, 2023

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 27, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #248 (b17cb99) into main (74d3be4) will increase coverage by 0.47%.
The diff coverage is 24.32%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #248      +/-   ##
==========================================
+ Coverage   36.48%   36.95%   +0.47%     
==========================================
  Files          16       16              
  Lines        1683     1675       -8     
==========================================
+ Hits          614      619       +5     
+ Misses       1027     1013      -14     
- Partials       42       43       +1     
Files Coverage Δ
pkg/investigations/chgm/chgm.go 66.23% <100.00%> (ø)
pkg/investigations/chgm/chgm_hibernation_check.go 94.44% <100.00%> (ø)
pkg/investigations/investigation.go 19.04% <ø> (ø)
pkg/utils/utils.go 68.18% <83.33%> (+43.18%) ⬆️
pkg/investigations/ccam/ccam.go 0.00% <0.00%> (ø)
pkg/ocm/mock/ocmmock.go 49.01% <0.00%> (-4.18%) ⬇️
pkg/ocm/ocm.go 0.00% <0.00%> (ø)

Copy link
Contributor

openshift-ci bot commented Nov 27, 2023

@typeid: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@RaphaelBut
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2023
Copy link
Contributor

openshift-ci bot commented Nov 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RaphaelBut, typeid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b6c97cd into openshift:main Nov 27, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants