Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use deprecated 'securityGroupId' in verifier library #300

Conversation

AlexVulaj
Copy link
Contributor

In the network verifier library, securityGroupId has long been deprecated in favor of securityGroupIds. This PR moves us over to use the latter so we aren't using a deprecated field.

Copy link
Contributor

openshift-ci bot commented Jul 9, 2024

@AlexVulaj: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 38.51%. Comparing base (71bd68e) to head (11363a1).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #300   +/-   ##
=======================================
  Coverage   38.51%   38.51%           
=======================================
  Files          20       20           
  Lines        1594     1594           
=======================================
  Hits          614      614           
  Misses        940      940           
  Partials       40       40           
Files Coverage Δ
pkg/networkverifier/networkverifier.go 46.59% <66.66%> (ø)

@tnierman
Copy link
Member

tnierman commented Jul 9, 2024

/lgtm
/approve
/honk

Copy link
Contributor

openshift-ci bot commented Jul 9, 2024

@tnierman:
goose image

In response to this:

/lgtm
/approve
/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2024
@RaphaelBut
Copy link
Contributor

thanks @AlexVulaj ! ;)

/approve

@RaphaelBut
Copy link
Contributor

/honk

Copy link
Contributor

openshift-ci bot commented Jul 10, 2024

@RaphaelBut:
goose image

In response to this:

/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Jul 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexVulaj, RaphaelBut, tnierman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit c358e70 into openshift:main Jul 10, 2024
5 checks passed
@AlexVulaj AlexVulaj deleted the verifier-security-group-id-deprecated branch July 10, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants