Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump openshift/api to get customize catalog categories changes #484

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Bump openshift/api to get customize catalog categories changes #484

merged 1 commit into from
Dec 4, 2020

Conversation

christoph-jerolimov
Copy link
Member

@christoph-jerolimov christoph-jerolimov commented Nov 23, 2020 •
edited
Loading

Issue: https://issues.redhat.com/browse/ODC-5020

Update openshift/api in vendor folder to get the latest update from openshift/api#763

(Does not include a go.mod/sum update yet, will update this PR when the api PR is merged.)

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 23, 2020
@christoph-jerolimov christoph-jerolimov changed the title [WIP] Bump openshift/api to get customize catalog categories changes Bump openshift/api to get customize catalog categories changes Nov 23, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 23, 2020
@christoph-jerolimov
Copy link
Member Author

/assign @spadgett @jhadvig

@christoph-jerolimov christoph-jerolimov force-pushed the odc-5020 branch 2 times, most recently from 1c8b5ed to e8f05b8 Compare November 24, 2020 11:31
@jhadvig
Copy link
Member

jhadvig commented Nov 26, 2020

/retest

2 similar comments
@christoph-jerolimov
Copy link
Member Author

/retest

@christoph-jerolimov
Copy link
Member Author

/retest

@christoph-jerolimov
Copy link
Member Author

extensions_crud_test.go:16: Console.operator.openshift.io "cluster" is invalid: spec.customization.developerCatalog.categories: Invalid value: "null": spec.customization.developerCatalog.categories in body must be of type array: "null"

Added omitempty to customization.developerCatalog and customization.developerCatalog.categories

@christoph-jerolimov
Copy link
Member Author

/retest

1 similar comment
@christoph-jerolimov
Copy link
Member Author

/retest

@jhadvig
Copy link
Member

jhadvig commented Dec 1, 2020

Added couple of comments to the API PR

@christoph-jerolimov
Copy link
Member Author

@jhadvig I have accepted all suggestions and rebased this PR.

@christoph-jerolimov christoph-jerolimov force-pushed the odc-5020 branch 3 times, most recently from 0131f97 to b7f899b Compare December 3, 2020 13:12
@christoph-jerolimov
Copy link
Member Author

/retest

1 similar comment
@christoph-jerolimov
Copy link
Member Author

/retest

@christoph-jerolimov
Copy link
Member Author

/retest

@jhadvig
Copy link
Member

jhadvig commented Dec 4, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, jhadvig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2020
@openshift-merge-robot openshift-merge-robot merged commit 6ba14c9 into openshift:master Dec 4, 2020
@christoph-jerolimov christoph-jerolimov mentioned this pull request Dec 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhadvig jhadvig Awaiting requested review from jhadvig

@spadgett spadgett Awaiting requested review from spadgett

Assignees

@spadgett spadgett

@jhadvig jhadvig

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@christoph-jerolimov @jhadvig @openshift-ci-robot @spadgett @openshift-merge-robot