Merge pull request #14547 from logonoff/namesp

OCPBUGS-44920: save all `window.windowError`s for easier debugging
openshift · Dec 5, 2024 · 74d43c1 · 74d43c1
2 parents 859242b + 4325269
commit 74d43c1
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 9 deletions.
diff --git a/frontend/@types/console/index.d.ts b/frontend/@types/console/index.d.ts
@@ -57,7 +57,7 @@ declare interface Window {
     k8sMode: string;
     capabilities: Record<string, string>[];
   };
-  windowError?: string;
+  windowError?: string[];
   __REDUX_DEVTOOLS_EXTENSION_COMPOSE__?: Function;
   i18n?: {}; // i18next instance, only available in development builds for debugging
   store?: {}; // Redux store, only available in development builds for debugging

diff --git a/frontend/packages/console-dynamic-plugin-sdk/@types/sdk/index.d.ts b/frontend/packages/console-dynamic-plugin-sdk/@types/sdk/index.d.ts
@@ -2,6 +2,6 @@ declare interface Window {
   SERVER_FLAGS: {
     basePath: string;
   };
-  windowError?: string;
+  windowError?: string[];
   __REDUX_DEVTOOLS_EXTENSION_COMPOSE__?: Function;
 }
diff --git a/frontend/packages/integration-tests-cypress/support/index.ts b/frontend/packages/integration-tests-cypress/support/index.ts
@@ -8,6 +8,10 @@ import { a11yTestResults } from './a11y';
 import './admin';
 
 declare global {
+  interface Window {
+    windowError?: string[];
+  }
+
   namespace Cypress {
     interface Chainable {
       visitAndWait(
@@ -82,8 +86,8 @@ after(() => {
 });
 
 export const checkErrors = () =>
-  cy.window().then((win) => {
-    assert.isTrue(!win.windowError, win.windowError);
+  cy.window().then(({ windowError }) => {
+    assert.isTrue(!windowError || windowError.length === 0, String(windowError));
   });
 
 export const testName = `test-${Math.random()

diff --git a/frontend/public/components/app.jsx b/frontend/public/components/app.jsx
@@ -590,18 +590,18 @@ graphQLReady.onReady(() => {
   setInterval(() => store.dispatch(UIActions.updateTimestamps(Date.now())), 10000);
 
   // Used by GUI tests to check for unhandled exceptions
-  window.windowError = null;
+  window.windowError = [];
   window.onerror = (message, source, lineno, colno, error) => {
     const formattedStack = error?.stack?.replace(/\\n/g, '\n');
     const formattedMessage = `unhandled error: ${message} ${formattedStack || ''}`;
-    window.windowError = formattedMessage;
+    window.windowError.push(formattedMessage);
     // eslint-disable-next-line no-console
     console.error(formattedMessage, error || message);
   };
   window.onunhandledrejection = (promiseRejectionEvent) => {
     const { reason } = promiseRejectionEvent;
     const formattedMessage = `unhandled promise rejection: ${reason}`;
-    window.windowError = formattedMessage;
+    window.windowError.push(formattedMessage);
     // eslint-disable-next-line no-console
     console.error(formattedMessage, reason);
   };

diff --git a/frontend/public/i18n.js b/frontend/public/i18n.js
@@ -109,9 +109,10 @@ export const init = () => {
       },
       saveMissing: true,
       missingKeyHandler: function (lng, ns, key) {
-        window.windowError = `Missing i18n key "${key}" in namespace "${ns}" and language "${lng}".`;
+        const error = `Missing i18n key "${key}" in namespace "${ns}" and language "${lng}".`;
+        window.windowError = [...(window.windowError || []), error]; // OCPBUGS-45139: store all i18n errors for easy debugging
         // eslint-disable-next-line no-console
-        console.error(window.windowError);
+        console.error(error);
       },
     })
     // Update loading promise and pass values and errors to the caller