Skip to content

OCPBUGS-1470: i18n Incorrect plural for maxUnavailable pod count #12065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Oct 19, 2022
Merged

OCPBUGS-1470: i18n Incorrect plural for maxUnavailable pod count #12065

openshift-merge-robot merged 1 commit into from
Oct 19, 2022

Conversation

@cajieh
Copy link
Contributor

@cajieh cajieh commented Sep 19, 2022

Before

Screen Shot 2022-09-19 at 2 29 41 PM

After

Screen Shot 2022-09-19 at 2 51 27 PM

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 19, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 19, 2022

@cyril-ui-developer: This pull request references Jira Issue OCPBUGS-1470, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.0) matches configured target version for branch (4.12.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Before

Screen Shot 2022-09-19 at 2 29 41 PM

After

Screen Shot 2022-09-19 at 2 51 27 PM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from jhadvig, kyoto and yapei September 19, 2022 18:56
@openshift-ci openshift-ci bot added component/core Related to console core functionality kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Sep 19, 2022
@cajieh
Copy link
Contributor Author

cajieh commented Sep 20, 2022

/retest

sg00dwin
sg00dwin approved these changes Sep 20, 2022
View reviewed changes
Copy link
Member

@sg00dwin sg00dwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2022
jhadvig
jhadvig approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cyril-ui-developer, jhadvig, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 30, 2022

/retest-required

Remaining retests: 0 against base HEAD 9852360 and 2 for PR HEAD 12f3f55 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 4, 2022

/retest-required

Remaining retests: 0 against base HEAD 0780f4c and 1 for PR HEAD 12f3f55 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 4, 2022

/retest-required

Remaining retests: 0 against base HEAD 0e6acaa and 0 for PR HEAD 12f3f55 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 5, 2022

/hold

Revision 12f3f55 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2022
@cajieh
Copy link
Contributor Author

cajieh commented Oct 18, 2022

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 18, 2022
@cajieh
Copy link
Contributor Author

cajieh commented Oct 18, 2022

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2022

@cyril-ui-developer: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 0121e90 into openshift:master Oct 19, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 19, 2022

@cyril-ui-developer: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-1470 has been moved to the MODIFIED state.

Details

In response to this:

Before

Screen Shot 2022-09-19 at 2 29 41 PM

After

Screen Shot 2022-09-19 at 2 51 27 PM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coderabbitai coderabbitai bot mentioned this pull request Nov 19, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhadvig jhadvig jhadvig approved these changes

@sg00dwin sg00dwin sg00dwin approved these changes

@yapei yapei Awaiting requested review from yapei

@kyoto kyoto Awaiting requested review from kyoto

Assignees

@sg00dwin sg00dwin

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cajieh @openshift-ci-robot @jhadvig @sg00dwin @openshift-merge-robot