OCPBUGS-52479: Fix OLM e2e tests

[vikram-raj]

[vikram-raj]

/test e2e-gcp-console-olm

[openshift-ci]

@vikram-raj: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test analyze

/test backend

/test e2e-gcp-console

/test frontend

/test images

/test okd-scos-images

The following commands are available to trigger optional jobs:

/test okd-scos-e2e-aws-ovn

Use /test all to run all jobs.

Details

In response to this:

/test e2e-gcp-console-olm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

@vikram-raj: This pull request references Jira Issue OCPBUGS-52479, which is invalid:

• expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[vikram-raj]

/jira refresh

[openshift-ci-robot]

@vikram-raj: This pull request references Jira Issue OCPBUGS-52479, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.0) matches configured target version for branch (4.19.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[vikram-raj]

/retest

[vikram-raj]

/cc @rhamilto

[vikram-raj]

/retest

[rhamilto]

@vikram-raj, I just noticed I cannot run select console tests locally without manually dismissing the modal (e.g., https://github.com/openshift/console/blob/main/frontend/packages/integration-tests-cypress/tests/crd-extensions/console-external-log-link.cy.ts). Any test without a cy.initAdmin(); is affected.

[rhamilto]

And long term, simply adding cy.initAdmin(); may be short-sighted since the perspective switcher is likely to not be present when the Developer perspective is removed as the time it takes to check the perspective is what allows subsequent tests to run as it allows enough time to ensure the console is fully loaded before proceeding.

[logonoff]

/lgtm
/label acknowledge-critical-fixes-only

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/packages/integration-tests-cypress/OWNERS [logonoff,vikram-raj]
• frontend/packages/operator-lifecycle-manager/OWNERS [logonoff,vikram-raj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD dd87a16 and 2 for PR HEAD f88f1aa in total

[rhamilto]

@logonoff, it's certainly ok to merge this, but note the admin tour was disabled with #14866, so it isn't really buying us anything. And see #14851 (comment).

[logonoff]

@logonoff, it's certainly ok to merge this, but note the admin tour was disabled with #14866, so it isn't really buying us anything. And see #14851 (comment).

I was thinking the admin tour will need to be re-enabled eventually, so this while the merge queue was empty this was a good time to get this fix in.

While the perspective switcher was removed, I kept an empty and hidden div in the DOM in place of the perspective switcher, to serve the purpose of the checking whether console is fully loaded yet. In a followup I may try to remove the div but I don't think it's too important

[openshift-ci]

@vikram-raj: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@vikram-raj: Jira Issue OCPBUGS-52479: All pull requests linked via external trackers have merged:

• openshift/console#14851

Jira Issue OCPBUGS-52479 has been moved to the MODIFIED state.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.