Skip to content

CONSOLE-4756: Convert more files to TypeScript #15472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 6 commits into from
Sep 16, 2025
Merged

CONSOLE-4756: Convert more files to TypeScript #15472

openshift-merge-bot merged 6 commits into from
Sep 16, 2025

Conversation

@logonoff
Copy link
Member

@logonoff logonoff commented Sep 8, 2025

TODO: figure out how to generate PersistentVolumeKind, ConsoleLinkKind, etc. types based off of the resource definitions to avoid diverging types

refactor the following files to TS:

  • persistent-volume.jsx
  • masthead-toolbar.jsx
  • prometheus.jsx
  • confirm-modal.jsx
  • inject.js

/label px-approved
/label docs-approved

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 8, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 8, 2025 •
edited by openshift-ci bot
Loading

@logonoff: This pull request references CONSOLE-4756 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

TODO: figure out how to generate PersistentVolumeKind, ConsoleLinkKind, etc. types based off of the resource definitions to avoid diverging types

refactor the following files to TS:

  • persistent-volume.jsx
  • masthead-toolbar.jsx
  • prometheus.jsx
  • confirm-modal.jsx
  • inject.js

/label px-approved
/label docs-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Sep 8, 2025
@openshift-ci openshift-ci bot requested review from TheRealJon and jhadvig September 8, 2025 16:51
@openshift-ci openshift-ci bot added component/core Related to console core functionality kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 8, 2025
@logonoff
CONSOLE-4756: Migrate PersistentVolume page to TS
2f4b1f3 
TODO: figure out how to generate `PersistentVolumeKind`, etc. types based off of the resource swagger definitions to avoid diverging types

/label px-approved
/label docs-approved
@logonoff logonoff force-pushed the CONSOLE-4756-typescriptification-3 branch from 4243141 to 09aec9c Compare September 8, 2025 16:51
@logonoff
Copy link
Member Author

logonoff commented Sep 8, 2025

qe review:
/assign @yanpzhan

code review:
/assign @rhamilto

@logonoff logonoff force-pushed the CONSOLE-4756-typescriptification-3 branch 2 times, most recently from 2757e00 to 8d9082f Compare September 9, 2025 02:34
@logonoff
Copy link
Member Author

logonoff commented Sep 9, 2025

/retest

@logonoff logonoff force-pushed the CONSOLE-4756-typescriptification-3 branch from 8d9082f to ce0e100 Compare September 10, 2025 14:33
TheRealJon
TheRealJon approved these changes Sep 12, 2025
View reviewed changes
Copy link
Member

@TheRealJon TheRealJon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@logonoff
Copy link
Member Author

logonoff commented Sep 12, 2025

/assign @yapei

@yanpzhan
Copy link
Contributor

yanpzhan commented Sep 15, 2025

Regression test passed on cluster launched against the pr.
/verified by @yanpzhan

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 15, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 15, 2025

@yanpzhan: This PR has been marked as verified by @yanpzhan.

Details

In response to this:

Regression test passed on cluster launched against the pr.
/verified by @yanpzhan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff
Copy link
Member Author

logonoff commented Sep 15, 2025

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 15, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 15, 2025 •
edited by openshift-ci bot
Loading

@logonoff: This pull request references CONSOLE-4756 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

TODO: figure out how to generate PersistentVolumeKind, ConsoleLinkKind, etc. types based off of the resource definitions to avoid diverging types

refactor the following files to TS:

  • persistent-volume.jsx
  • masthead-toolbar.jsx
  • prometheus.jsx
  • confirm-modal.jsx
  • inject.js

/label px-approved
/label docs-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 15, 2025

/retest-required

Remaining retests: 0 against base HEAD b33ff3e and 2 for PR HEAD a3dffaa in total

1 similar comment
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 15, 2025

/retest-required

Remaining retests: 0 against base HEAD b33ff3e and 2 for PR HEAD a3dffaa in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 16, 2025

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 775ca53 into openshift:main Sep 16, 2025
8 checks passed
@logonoff logonoff deleted the CONSOLE-4756-typescriptification-3 branch September 16, 2025 11:35
@logonoff logonoff mentioned this pull request Oct 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheRealJon TheRealJon TheRealJon approved these changes

@jhadvig jhadvig Awaiting requested review from jhadvig

Assignees

@rhamilto rhamilto

@yanpzhan yanpzhan

@yapei yapei

@TheRealJon TheRealJon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@logonoff @openshift-ci-robot @yanpzhan @TheRealJon @rhamilto @yapei