Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubevirt VMTemplate create YAML #1865

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Jun 30, 2019

Add route and page for creating vm templates from YAML.

OKD(3)

OKD(4)

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 30, 2019
@yaacov
Copy link
Member Author

yaacov commented Jun 30, 2019

@mareklibra @vojtechszocs @suomiy @rawagner please review.

Copy link
Member

@atiratree atiratree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

but still has few issues

  • route to /k8s/cluster/vmtemplates/ does not exist
  • redirection from create yaml / vmtemplate list still links to /templates/my-template and not /vmtemplates/my-template

@atiratree
Copy link
Member

ignore my comment about the redirection - I see that this is being resolved by #1843

@yaacov
Copy link
Member Author

yaacov commented Jul 1, 2019

@suomiy 👍

Didn't see the .../cluster/... route before :-) , played with other resources and it looks like it behaves like all-namespaces ? so I added it in the same way, am I missing something here ?

@spadgett spadgett added this to the v4.2 milestone Jul 1, 2019
@atiratree
Copy link
Member

After looking at it the second time, I would remove the cluster route altogether for vmtemplates. It seems to me that it is meant for cluster wide resources like storageclasses.

@yaacov
Copy link
Member Author

yaacov commented Jul 2, 2019

After looking at it the second time, I would remove the cluster route altogether for vmtemplates. It seems to me that it is meant for cluster wide resources like storageclasses.

@suomiy makes sense 👍

I copied the cluster route from here:
https://github.com/openshift/console/blob/master/frontend/public/components/factory/list-page.jsx#L321

It looks like we do not need to support the cluster option for vms and vmtemplates .

@atiratree
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: suomiy, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2019
@openshift-merge-robot openshift-merge-robot merged commit 95222f3 into openshift:master Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants