-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kubevirt VMTemplate create YAML #1865
Kubevirt VMTemplate create YAML #1865
Conversation
@mareklibra @vojtechszocs @suomiy @rawagner please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
but still has few issues
- route to
/k8s/cluster/vmtemplates/
does not exist redirection fromcreate yaml
/vmtemplate list
still links to/templates/my-template
and not/vmtemplates/my-template
ignore my comment about the redirection - I see that this is being resolved by #1843 |
@suomiy 👍 Didn't see the |
After looking at it the second time, I would remove the cluster route altogether for vmtemplates. It seems to me that it is meant for cluster wide resources like storageclasses. |
@suomiy makes sense 👍 I copied the It looks like we do not need to support the |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: suomiy, yaacov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add route and page for creating vm templates from YAML.