Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to include dropDownClassName="dropdown--full-width" #1872

Conversation

sg00dwin
Copy link
Member

@sg00dwin sg00dwin commented Jul 1, 2019

to dropdowns that doesn't include autocomplete.

  • Make source-to-image "Version" dropdown full width.

Screen Shot 2019-07-01 at 1 29 44 PM

…ropdown> component that doesn't include autocomplete.
@sg00dwin sg00dwin requested a review from spadgett July 1, 2019 17:33
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 1, 2019
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 1, 2019
@spadgett
Copy link
Member

spadgett commented Jul 1, 2019

@rohitkrai03 fyi

@spadgett spadgett added this to the v4.2 milestone Jul 1, 2019
Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rohitkrai03, sg00dwin, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sg00dwin
Copy link
Member Author

sg00dwin commented Jul 1, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit a7fcec9 into openshift:master Jul 1, 2019
@sg00dwin sg00dwin deleted the add-dropdown-full-width-to-non-autocomplete-dropdowns branch July 1, 2019 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants