Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cluster Settings: show update errors using tooltips #2814

Merged
merged 1 commit into from
Sep 27, 2019
Merged

Cluster Settings: show update errors using tooltips #2814

merged 1 commit into from
Sep 27, 2019

Conversation

spadgett
Copy link
Member

/assign @rhamilto
cc @wking

Screen Shot 2019-09-23 at 9 32 03 AM

Screen Shot 2019-09-23 at 9 26 44 AM

Screen Shot 2019-09-23 at 9 15 44 AM

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. component/core Related to console core functionality labels Sep 23, 2019
@spadgett spadgett added this to the v4.3 milestone Sep 23, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2019
rhamilto
rhamilto reviewed Sep 23, 2019
View reviewed changes
frontend/public/components/cluster-settings/cluster-settings.tsx
@@ -129,10 +145,12 @@ export const CurrentVersion: React.SFC<CurrentVersionProps> = ({cv}) => {
if (status === ClusterUpdateStatus.UpToDate || status === ClusterUpdateStatus.UpdatesAvailable) {
return desiredVersion
? <span className="co-select-to-copy">{desiredVersion}</span>
: <React.Fragment><YellowExclamationTriangleIcon />&nbsp;Unknown</React.Fragment>;
: <><YellowExclamationTriangleIcon />&nbsp;Unknown</>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: you're using <React.Fragment> above (as are the previously existing examples).

rhamilto
rhamilto approved these changes Sep 23, 2019
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member Author

/hold
for #2817

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2019
@spadgett spadgett changed the base branch from master-4.3 to master September 25, 2019 18:39
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2019
@spadgett
Copy link
Member Author

/hold cancel

@rhamilto updated, another look?

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2019
rhamilto
rhamilto approved these changes Sep 26, 2019
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett
Copy link
Member Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member Author

/retest

1 similar comment
@spadgett
Copy link
Member Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 4d8dc3a into openshift:master Sep 27, 2019
@wking
Copy link
Member

wking commented Sep 27, 2019

Can we get a bug for this PR where QE can verify with this patch? Then we can clone/cherry-pick back to 4.2.

@spadgett spadgett deleted the error-retrieving-message branch May 1, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wking wking wking left review comments

@rhamilto rhamilto rhamilto approved these changes

@jhadvig jhadvig Awaiting requested review from jhadvig

Assignees

@rhamilto rhamilto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v4.3
Development

Successfully merging this pull request may close these issues.
6 participants
@spadgett @openshift-bot @openshift-ci-robot @wking @rhamilto @openshift-merge-robot