-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cluster Settings: show update errors using tooltips #2814
Cluster Settings: show update errors using tooltips #2814
Conversation
@@ -129,10 +145,12 @@ export const CurrentVersion: React.SFC<CurrentVersionProps> = ({cv}) => { | |||
if (status === ClusterUpdateStatus.UpToDate || status === ClusterUpdateStatus.UpdatesAvailable) { | |||
return desiredVersion | |||
? <span className="co-select-to-copy">{desiredVersion}</span> | |||
: <React.Fragment><YellowExclamationTriangleIcon /> Unknown</React.Fragment>; | |||
: <><YellowExclamationTriangleIcon /> Unknown</>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: you're using <React.Fragment>
above (as are the previously existing examples).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest Please review the full test history for this PR and help us cut down flakes. |
/hold |
frontend/public/components/cluster-settings/cluster-settings.tsx
Outdated
Show resolved
Hide resolved
88b709c
to
6e00cd3
Compare
6e00cd3
to
607f359
Compare
/hold cancel @rhamilto updated, another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhamilto, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest |
1 similar comment
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
Can we get a bug for this PR where QE can verify with this patch? Then we can clone/cherry-pick back to 4.2. |
/assign @rhamilto
cc @wking