-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1837421: Fetch latest upstream patches #28
Conversation
Change 'make test-vet' back to call 'go vet'
The final 1.3.0 release of the hostpath driver really uses the 1.3.0 driver image in its deployment, in contrast to the previous -rc candidates which still used 1.2.0.
prow.sh: use 1.3.0 hostpath driver for testing
Developers should not be forced to build for all platforms by default. We also don't want to copy-and-paste the go invocation for each new platform. To address both, the target platform(s) are now configurable via BUILD_PLATFORMS and additional platforms are only enabled in the Prow CI. For now this serves as a test that the source actually compiles for multiple platforms. Building images for different target platforms is a different problem.
build for multiple platforms only in CI, add s390x
Changes from testing before first release
Signed-off-by: Grant Griffiths <grant@portworx.com>
Update snapshotter to version 2.0.1
Change-Id: I1142fc76b939c03ba05070179b5ab9574c096571
Add .prow.sh to enable prow jobs
…image Change base image to centos:latest
Rename driver to follow CSI plugin naming conventions
Add basic info to README about the plugin compatibility and features
Add more access modes to volume capabilities
Change-Id: I369683a10673e9da15998ddd9056890db6154b69
Add 2.0 changelog
update release tools instructions
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fedosin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It's not a real file and thus should better be marked as phony.
Most repos inherit the default BUILD_PLATFORMS, which includes Windows, but don't have the necessary Dockerfile.Windows yet. To simplify the rollout of multiarch image builds, Windows binary building continues to be tested (i.e. BUILD_PLATFORMS remains unchanged), but push-multiarch skips Windows if the Dockerfile.Windows is missing.
multiarch windows fix
Commit summary: 340e082 build.make: optional inclusion of Windows in multiarch images 5231f05 build.make: properly declare push-multiarch 4569f27 build.make: fix push-multiarch ambiguity bd41690 cloud build: initial set of shared files 6f2322e Update patch release notes generation command d8c76fe Support local snapshot RBAC for pull jobs ea1f94a update release tools instructions 7edc146 Update snapshotter to version 2.0.1 3863a0f build for multiple platforms only in CI, add s390x 7c5a89c prow.sh: use 1.3.0 hostpath driver for testing
master: update release-tools
If the Dockerfile needs to run some command, that step fails unless QEMU is set up properly first: failed to solve: rpc error: code = Unknown desc = failed to load LLB: runtime execution on platform linux/ppc64le not supported
cloud build: initialize support for running commands in Dockerfile
As discussed in kubernetes/k8s.io#943, we want to consolidate under k8s-staging-sig-storage.
cloud build: k8s-staging-sig-storage
prow.sh: enable building arm64 image
master: update release-tools
For RWX volume, kubelet does not perform recursive ownership/permission change. The heuristics that kubelet uses is being modified via - kubernetes/enhancements#1682 Having said that, for RWX volumes which are made available via NFS protocol, using fsGroup is not recommended because if there are 2 pods that are trying to use same volume but with different fsGroup then one pod may lock out the other pod. To avoid this, we must be able to set the folder permissions to 777. This commit adds a cli option --mount-permissions, that allows to define custom permissions. If the value is not specified, then default permissions will be kept. Cherry-picked from: kubernetes-csi#36
Allow to set custom permissions for the mounted folder
@Fedosin: This pull request references Bugzilla bug 1837421, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Fedosin: This pull request references Bugzilla bug 1837421, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.5 |
@Fedosin: once the present PR merges, I will cherry-pick it on top of release-4.5 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Fedosin: All pull requests linked via external trackers have merged: openshift/csi-driver-nfs#28. Bugzilla bug 1837421 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Fedosin: new pull request created: #30 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No conflicts, just a fast-forward update.
The fix for the bug is: 070c69e