-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge https://github.com/kubernetes-csi/csi-driver-nfs:master into master #57
Merge https://github.com/kubernetes-csi/csi-driver-nfs:master into master #57
Conversation
Moves the ARCH build argument after the first FROM so it has the proper value. Default value is empty as required by release-tools/build.make. (https://docs.docker.com/engine/reference/builder/#understand-how-arg-and-from-interact) Adds the GOARM=7 option to the armv7 GO build.
…csiGH-239 fix: armv7 docker builds
Hi @shiftstack-merge-bot[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm Sounds like a minor change, but let's wait on CI to see. |
/hold cancel |
/approve |
1 similar comment
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM, shiftstack-merge-bot[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.