Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: Centralize injection of hosted-kubeconfig volume #311

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

stephenfin
Copy link
Contributor

We have hit a critical number of users of this now that the Cinder CSI driver is adding support for Hypershift too.

All that changes is the generated assets is the order of the volumes.

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
We can use the one meant for sidecars. One less thing to keep in sync.

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 25, 2024
@openshift-ci-robot
Copy link

@stephenfin: This pull request explicitly references no jira issue.

In response to this:

We have hit a critical number of users of this now that the Cinder CSI driver is adding support for Hypershift too.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from bertinatto and gnufied October 25, 2024 16:40
Copy link
Contributor

openshift-ci bot commented Oct 25, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stephenfin
Once this PR has been reviewed and has the lgtm label, please assign jsafrane for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Nov 9, 2024

@stephenfin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 700a8a6 link false /test security
ci/prow/e2e-azure 700a8a6 link true /test e2e-azure
ci/prow/e2e-azurestack-csi 700a8a6 link false /test e2e-azurestack-csi
ci/prow/smb-operator-e2e-extended 700a8a6 link false /test smb-operator-e2e-extended
ci/prow/e2e-openstack-manila-csi 700a8a6 link true /test e2e-openstack-manila-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants