OCPBUGS-54180: Disable remove-not-ready-taint for azure disk csi driver #371
Conversation
Phaow
commented
Mar 25, 2025
•
Phaow
commented
- Disable the remove-not-ready-taint feature, as it is not implemented in ocp, avoid the unnecessary remove taint actions and logs. (Try to make it opt-in on upstream but unfortunately the maintainer is not happy with it, so we could go head disable it from our operator side. https://redhat-internal.slack.com/archives/GK0DA0JR5/p1743062502904419?thread_ts=1742823634.580139&cid=GK0DA0JR5)
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Phaow
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
openshift-ci-robot
added
jira/severity-moderate
|
@Phaow: This pull request references Jira Issue OCPBUGS-54180, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
Phaow
changed the title
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@Phaow: This pull request references Jira Issue OCPBUGS-54180, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Hi @gnufied @mpatlasov , could you help take a look when you get a chance? Thank you! |
|
/assign @gnufied @mpatlasov |
|
@Phaow: This pull request references Jira Issue OCPBUGS-54180, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| @@ -23,6 +23,9 @@ spec: | |||
| # Use credentials provided by the azure-inject-credentials container | |||
| - --cloud-config-secret-name="" | |||
| - --cloud-config-secret-namespace="" | |||
| # Disable the remove-not-ready-taint, as it is not implemented in ocp | |||
| # https://github.com/kubernetes-sigs/azuredisk-csi-driver/pull/2309 | |||
| - --remove-not-ready-taint=false | |||
There was a problem hiding this comment.
Does controller part need anything?
There was a problem hiding this comment.
From my test result, from controller part, nothing else needed. In addition from upstream review https://github.com/kubernetes-sigs/azuredisk-csi-driver/pull/2976/files add the arg to the driver node is enough.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gnufied, Phaow The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
From CI logs I could see the unexpected permission issue and drain node action disable. |
openshift-ci
bot
added
acknowledge-critical-fixes-only
|
@Phaow: This pull request references Jira Issue OCPBUGS-54180, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: Phaow. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest-required |
|
/retest-required |
1 similar comment
|
/retest-required |
|
@Phaow: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
openshift-merge-bot
bot
merged commit 54b9f05
into
openshift:main
|
@Phaow: Jira Issue OCPBUGS-54180: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-54180 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
