Skip to content

Commit

Permalink
Add controller-runtime option to code section
Browse files Browse the repository at this point in the history
  • Loading branch information
yanirq committed Nov 10, 2021
1 parent 1a5e842 commit 049d107
Showing 1 changed file with 12 additions and 2 deletions.
14 changes: 12 additions & 2 deletions enhancements/node-tuning/pao-in-nto.md
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,8 @@ that can be used to
PAO code would be moved into the NTO repository as a separate controller. The Telco team would keep ownership as it has the necessary domain knowledge needed to implement the low latency tuning.

The code currently uses Operator SDK libraries in some of the tests and this might need to be changed.
Migrating the use of these libaries to [library-go](https://github.com/openshift/library-go)
would be one of the options.
Migrating the use of these libraries to [library-go](https://github.com/openshift/library-go) or stripping them to [controller-runtime](https://github.com/kubernetes-sigs/controller-runtime)
would be options in hand.

PAO also implements a [conversion webhook](https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definition-versioning/#webhook-conversion)
The hook is currently installed via OLM mechanisms and this might need to be reimplemented or changed to use whatever CVO or ART support.
Expand Down Expand Up @@ -147,6 +147,9 @@ The bugzilla component is currently not part of OCP metrics and we can include i

Both the NTO and PAO functionality should be kept intact and no regressions are allowed. The user should not notice anything except the fact that OLM is no longer needed to enable the tuning functionality.

### API Extensions
The existing PAO API Extensions will be moved under the NTO repository.

### Implementation Details/Notes/Constraints

- Existing api compatibility practices:
Expand Down Expand Up @@ -200,6 +203,7 @@ NTO currently supports only one cloud installation with external control plane t
- Implementation:
- Remove the relevant OLM artifacts (CSV,Subscription,Operator group) via the performance-addon controller and leave the PAO CRDs without the change.
- In case leader election supports such conditioning, is to keep using the same leadership election method and make sure the newest version always wins. The OLM operator will then stay on the cluster (can be release noted) as an inactive component.

### Test Plan

All tests already exist in OCP CI, the trigger will move to the NTO repository.
Expand Down Expand Up @@ -280,6 +284,12 @@ enhancement:
- Will any other components on the node change? For example, changes to CSI, CRI
or CNI may require updating that component before the kubelet.

### Operational Aspects of API Extensions

#### Failure Modes

#### Support Procedures

## Implementation History

Major milestones in the life cycle of a proposal should be tracked in `Implementation
Expand Down

0 comments on commit 049d107

Please sign in to comment.