Skip to content

Commit

Permalink
fix: template changes
Browse files Browse the repository at this point in the history
Signed-off-by: thejasn <thn@redhat.com>
  • Loading branch information
thejasn committed May 4, 2022
1 parent 6f05603 commit 66a4316
Showing 1 changed file with 17 additions and 17 deletions.
34 changes: 17 additions & 17 deletions enhancements/ingress/aws-load-balancer-operator.md
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,23 @@ the created load balancer will be configured to route traffic through a NodePort
service. Setting the annotation to _ip_ is not huge risk, since it only works when
the cluster uses the Amazon VPC CNI and hence will not work on OCP/OKD clusters.

### Drawbacks

Since we are reusing an existing upstream controller and restricting which of its
features are enabled, some upstream documentation would not be applicable for this
operator.

The _lb-controller_ currently has support for _Service_ type resources as well.
When the annotation `service.beta.kubernetes.io/aws-load-balancer-type: "external"`
is specified on a _Service_ resource of type _LoadBalancer_ the in-tree controller
ignores this resource and the lb-controller instead provisions a Network Load
Balancer with the correct configuration.
The operator utilises the `service-ca-controller` to generate and inject certificates
using the associated secret. Currently upon renewal of these certificates, the operator
does not reload the deployment. Dynamic reload of the deployment isn't supported in
the initial release.

#### Parallel operation of the OpenShift router and lb-controller

The OpenShift router manages ingresses that don’t have any ingress class value.
Expand Down Expand Up @@ -419,23 +436,6 @@ TBD
- Updates test plan and current caveats in testing
- Removes non-applicable details for initial release

## Drawbacks

Since we are reusing an existing upstream controller and restricting which of its
features are enabled, some upstream documentation would not be applicable for this
operator.

The _lb-controller_ currently has support for _Service_ type resources as well.
When the annotation `service.beta.kubernetes.io/aws-load-balancer-type: "external"`
is specified on a _Service_ resource of type _LoadBalancer_ the in-tree controller
ignores this resource and the lb-controller instead provisions a Network Load
Balancer with the correct configuration.
The operator utilises the `service-ca-controller` to generate and inject certificates
using the associated secret. Currently upon renewal of these certificates, the operator
does not reload the deployment. Dynamic reload of the deployment isn't supported in
the initial release.

## Alternatives

The existing OpenShift router could be modified to provision ALBs for Ingresses
Expand Down

0 comments on commit 66a4316

Please sign in to comment.