flow-control-api spec

[pmoogi-redhat]

As a cluster admin I want to be able to set a flow control policy or logging rate limiting policy : drop as if logging rate exceeds rate limits provided (bytes/sec) on selected containers, ignore by dropping entire logs from selected group of containers.

*A cluster-wide default for all containers (optional)
*A special rate for containers in named namespaces
*A special rate for containers matching a label selector
*Rates are per-container and measured in bytes/sec, the default value -1 means no limits are applied (default behaviour), 0 - means ignore entirely that set of selected containers logs belonging to a defined group

Rates are enforced by dropping log data if it exceeds the rate. Cluster Logging Forwarder Spec applies RateLimiting policies to its input sources of logs and also its output endpoints connecting to a given persistent storage.

JIRA Reference [Epic] - https://issues.redhat.com/browse/LOG-884
JIRA Reference [Story] - https://issues.redhat.com/browse/LOG-2207

[pmoogi-redhat]

@alanconway please review

[alanconway]

Made some suggested changes, you can apply them automatically via github. Important points:

• changed input.limit to input.perContainerLimit
• changed limit.maxBytesPerSecond to input.MaxRecordsPerSecond

[alanconway]

@pmoogiThis should be linked to https://issues.redhat.com/browse/LOG-1043 - that task is specifically for designing the API.
https://issues.redhat.com/browse/LOG-2207 is about implementing it.

[alanconway]

I have some updates from recent discussion to be included as soon as I get a chance to write them up.
/hold

[alanconway]

/unhold
/lgtm

[alanconway]

I will update in a separate PR.

[alanconway]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alanconway

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• enhancements/cluster-logging/OWNERS [alanconway]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[alanconway]

/approved

[openshift-ci]

@pmoogi-redhat: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.