Agent Installer Development Environment #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romfreiman
reviewed
Feb 16, 2022
romfreiman
reviewed
Feb 16, 2022
hardys
reviewed
Feb 16, 2022
hardys
reviewed
Feb 16, 2022
hardys
reviewed
Feb 16, 2022
hardys
reviewed
Feb 16, 2022
hardys
reviewed
Feb 16, 2022
hardys
reviewed
Feb 16, 2022
andfasano
reviewed
Feb 17, 2022
dhellmann
reviewed
Feb 21, 2022
lranjbar
force-pushed
the
agent-installer-e2e-tests
branch
from
5df4e4e
to
7101fd2
Compare
dhellmann
reviewed
Mar 7, 2022
lranjbar
force-pushed
the
agent-installer-e2e-tests
branch
from
7101fd2
to
3344d5c
Compare
dhellmann
reviewed
Mar 8, 2022
lranjbar
force-pushed
the
agent-installer-e2e-tests
branch
from
3344d5c
to
214dc4d
Compare
zaneb
reviewed
Mar 9, 2022
rwsu
reviewed
Mar 9, 2022
andfasano
reviewed
Mar 11, 2022
lranjbar
force-pushed
the
agent-installer-e2e-tests
branch
from
214dc4d
to
6d547ae
Compare
lranjbar
changed the title
lranjbar
force-pushed
the
agent-installer-e2e-tests
branch
from
6d547ae
to
c509d08
Compare
andfasano
reviewed
Mar 25, 2022
hardys
reviewed
Mar 25, 2022
zaneb
reviewed
Mar 25, 2022
lranjbar
force-pushed
the
agent-installer-e2e-tests
branch
from
c509d08
to
5a5fa47
Compare
lranjbar
force-pushed
the
agent-installer-e2e-tests
branch
from
5a5fa47
to
479b816
Compare
dhellmann
reviewed
Mar 30, 2022
Co-authored-by: Doug Hellmann <dhellmann@redhat.com>
Co-authored-by: Doug Hellmann <dhellmann@redhat.com>
Co-authored-by: Doug Hellmann <dhellmann@redhat.com>
Co-authored-by: Doug Hellmann <dhellmann@redhat.com>
andfasano
reviewed
Mar 31, 2022
rwsu
reviewed
Mar 31, 2022
zaneb
reviewed
Mar 31, 2022
|
/lgtm |
|
I'm happy with this version. I'll leave it open for other reviewers to comment before we approve it. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: celebdor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@lranjbar: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enhancement is looking to define a baseline for the e2e testing framework for the new ephemeral agent installer project.