Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NE-780: ingress: Add tunable-router-kubelet-probes #1039

Merged
merged 1 commit into from
Mar 30, 2022
Merged

NE-780: ingress: Add tunable-router-kubelet-probes #1039

merged 1 commit into from
Mar 30, 2022

Conversation

Miciah
Copy link
Contributor

@Miciah Miciah commented Feb 21, 2022 •
edited
Loading

This enhancement allows cluster administrators to modify the liveness and readiness probe timeout values of OpenShift router deployments.

  • enhancements/ingress/tunable-router-kubelet-probes.md: New file.

@Miciah Miciah force-pushed the add-tunable-router-kubelet-probes branch from 12bb689 to 475ee57 Compare February 22, 2022 00:46
@Miciah
Copy link
Contributor Author

Miciah commented Mar 7, 2022

/assign @rfredette

@rfredette
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2022
@Miciah
ingress: Add tunable-router-kubelet-probes
478aae6 
* enhancements/ingress/tunable-router-kubelet-probes.md: New file.
@Miciah Miciah force-pushed the add-tunable-router-kubelet-probes branch from 475ee57 to 478aae6 Compare March 29, 2022 03:51
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 29, 2022

@Miciah: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@frobware
Copy link
Contributor

Ultimately I'd like to draw a conclusion on why we see sporadic probe failures, particularly on [customer] production clusters.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2022
@frobware
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frobware

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2022
@openshift-merge-robot openshift-merge-robot merged commit 313aaed into openshift:master Mar 30, 2022
@Miciah Miciah mentioned this pull request Apr 7, 2022
Merged
@Miciah Miciah changed the title ingress: Add tunable-router-kubelet-probes NE-780: ingress: Add tunable-router-kubelet-probes Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhellmann dhellmann Awaiting requested review from dhellmann

@imcleod imcleod Awaiting requested review from imcleod

Assignees

@rfredette rfredette

@frobware frobware

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Miciah @rfredette @frobware @openshift-merge-robot