Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NE-585 Update enhancement after implementation #1054

Merged
merged 1 commit into from
May 9, 2022
Merged

NE-585 Update enhancement after implementation #1054

merged 1 commit into from
May 9, 2022

Conversation

candita
Copy link
Contributor

@candita candita commented Mar 7, 2022 •
edited
Loading

@openshift-ci openshift-ci bot requested review from dhellmann and squeed March 7, 2022 22:29
@sdodson
Copy link
Member

sdodson commented Mar 8, 2022 •
edited
Loading

If the PR description here linked to the PR with the implementation that matches this I'd be happy to approve and merge this.

@candita candita force-pushed the NE-585HealthCheckInterval branch 4 times, most recently from 571466e to ef6c3c6 Compare March 9, 2022 21:22
@candita
Copy link
Contributor Author

candita commented Mar 9, 2022

@sdodson @deads2k would you like to review this? I think I've made the last additions.

@openshift-bot
Copy link

Inactive enhancement proposals go stale after 28d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Mark the proposal as fresh by commenting /remove-lifecycle stale.
Stale proposals rot after an additional 7d of inactivity and eventually close.
Exclude this proposal from closing by commenting /lifecycle frozen.

If this proposal is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 7, 2022
@candita
Copy link
Contributor Author

candita commented Apr 13, 2022

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 13, 2022
@candita
Copy link
Contributor Author

candita commented Apr 13, 2022

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 13, 2022
@candita
Copy link
Contributor Author

candita commented Apr 26, 2022

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2022
@candita
Copy link
Contributor Author

candita commented Apr 27, 2022

@sdodson @Miciah @deads2k I've made the final updates on this, post-implementation. Could you PTAL?

@candita candita force-pushed the NE-585HealthCheckInterval branch 3 times, most recently from 404bd3c to d30583b Compare April 27, 2022 20:16
@rfredette
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2022
@Miciah
Copy link
Contributor

Miciah commented May 9, 2022

Thanks!
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2022
@Miciah
Copy link
Contributor

Miciah commented May 9, 2022 •
edited
Loading

The linter has a new requirement:

 enhancements/ingress/haproxy-healthcheckinterval.md missing "### Workflow Description"

This requirement is redundant because the topic is already covered by the "User Stories" and "Open Questions" sections, and the requirement wasn't there when the PR was posted, so I'm overriding it.

/override ci/prow/markdownlint

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 9, 2022

@Miciah: Overrode contexts on behalf of Miciah: ci/prow/markdownlint

In response to this:

The linter has a new requirement:

enhancements/ingress/haproxy-max-connections-tuning.md missing "### Workflow Description"

This requirement is redundant because the topic is already covered by the "User Stories" and "Open Questions" sections, and the requirement wasn't there when the PR was posted, so I'm overriding it.

/override ci/prow/markdownlint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 9, 2022

@candita: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@candita
Copy link
Contributor Author

candita commented May 9, 2022

#linter change added 3 days ago
/override

@openshift-merge-robot openshift-merge-robot merged commit 34ba81c into openshift:master May 9, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 9, 2022

@candita: /override requires a failed status context to operate on, but none was given

In response to this:

#linter change added 3 days ago
/override

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhellmann dhellmann Awaiting requested review from dhellmann

@squeed squeed Awaiting requested review from squeed

Assignees

@rfredette rfredette

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@candita @sdodson @openshift-bot @rfredette @Miciah @openshift-merge-robot