-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the various event files produced by CI #1066
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's give deads a few days for the upstream stuff he's on but then ping him about this next week. We'll definitely need his clarification.
dev-guide/ci/events-files.md
Outdated
* [Example](https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/logs/periodic-ci-openshift-release-master-ci-4.11-upgrade-from-stable-4.10-e2e-gcp-ovn-upgrade/1505747388038385664/artifacts/e2e-gcp-ovn-upgrade/gather-must-gather/artifacts/event-filter.html) | ||
* Tip: wait several seconds for the html page to finish rendering so you can use the text entry boxes to search | ||
|
||
* events.json (same as events except as json) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as event-filter.html.
dev-guide/ci/events-files.md
Outdated
* events (same as events.json except not json) | ||
* generated via `oc get events --all-namespaces` (see [source code](https://github.com/openshift/release/blob/f5017d5136a740a4186477b02bed70047ade200b/ci-operator/step-registry/gather/extra/gather-extra-commands.sh#L62)) | ||
* located in the prow job stored artifacts at `.../gahter-extra/artifacts/oc_cmds/events` | ||
* [Example](https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/logs/periodic-ci-openshift-release-master-ci-4.11-upgrade-from-stable-4.10-e2e-gcp-ovn-upgrade/1505747388038385664/artifacts/e2e-gcp-ovn-upgrade/gather-extra/artifacts/oc_cmds/events) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't know this one existed.
|
||
* We talked about events related to [Devan's PR](https://github.com/openshift/origin/pull/26862) which we can document | ||
more later | ||
* These events are Monitor events (received by a Watcher) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought these were the e2e-events above but now I'm not so sure. :)
dev-guide/ci/events-files.md
Outdated
* e2e-events_(date)-(number).json | ||
* located in the prow job stored artifacts at `.../<test_name>/openshift-e2e-test/artifacts/junit`; there are two of them | ||
* The smaller one contains ... | ||
* The bigger one contains ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding was you get two files if you invoke openshift-tests twice, as we do for upgrade jobs.
Inactive enhancement proposals go stale after 28d of inactivity. See https://github.com/openshift/enhancements#life-cycle for details. Mark the proposal as fresh by commenting If this proposal is safe to close now please do so with /lifecycle stale |
dev-guide/ci/events-files.md
Outdated
|
||
* event-filter.html | ||
* included in the output of a `oc adm must-gather` | ||
* contains the events from all namespaces plus events that exist in the kube-apiserver at the time `oc adm must-gather` was run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not all events, just the events in namespaces gathered by must-gather. so namespaces not listed as relatedResources for clusteroperators will be missing.
dev-guide/ci/events-files.md
Outdated
* [Example](https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/logs/periodic-ci-openshift-release-master-ci-4.11-upgrade-from-stable-4.10-e2e-gcp-ovn-upgrade/1505747388038385664/artifacts/e2e-gcp-ovn-upgrade/gather-extra/artifacts/events.json) | ||
|
||
* events (same as `gather-extra/artifacts/events.json` except not json) | ||
* generated via `oc get events --all-namespaces` (see [source code](https://github.com/openshift/release/blob/f5017d5136a740a4186477b02bed70047ade200b/ci-operator/step-registry/gather/extra/gather-extra-commands.sh#L62)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this one is all the events present in the apiserver at the end.
dev-guide/ci/events-files.md
Outdated
* [Example](https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/logs/periodic-ci-openshift-release-master-ci-4.11-upgrade-from-stable-4.10-e2e-gcp-ovn-upgrade/1505747388038385664/artifacts/e2e-gcp-ovn-upgrade/gather-extra/artifacts/oc_cmds/events) | ||
|
||
* resource-events_(date)-(number).zip | ||
* located in the prow job stored artifacts at `.../<test_name>/openshift-e2e-test/artifacts/junit`; there are two of them (not sure why?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two different openshift-tests invocations.
-rw-rw-r-- 1 dperique dperique 86468 Dec 31 1979 events.json | ||
``` | ||
|
||
* e2e-events_(date)-(number).json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are monitor events, not API events. the monitor is part of the openshift-tests invocation. They do not have the same info as the API events.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be worth the bother of renaming these? I believe this is fairly confusing for anyone who encounters them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be worth the bother of renaming these? I believe this is fairly confusing for anyone who encounters them.
I'd merge it. I'd also merge a PR to write the raw events separate from the computed ones.
* located in the prow job stored artifacts at `.../gahter-extra/artifacts/oc_cmds/events` | ||
* [Example](https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/logs/periodic-ci-openshift-release-master-ci-4.11-upgrade-from-stable-4.10-e2e-gcp-ovn-upgrade/1505747388038385664/artifacts/e2e-gcp-ovn-upgrade/gather-extra/artifacts/oc_cmds/events) | ||
|
||
* resource-events_(date)-(number).zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these contain kube-apiserver events.
dev-guide/ci/events-files.md
Outdated
|
||
* core/events.yaml | ||
* located in the must-gather.tar at `.../namespaces/(aNamespace)/core/events.yaml`; there is apparently one per namespace. | ||
* ??? (I could not find where this is produced) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is created by oc adm inspect
, which is called by must-gather.
dev-guide/ci/events-files.md
Outdated
To aid in debugging, the Openshift CI (prow) produces various files related to events. The files | ||
reside in the gather-must-gather and gather-extra subdirectories in the artifacts storage area. | ||
You will see the "Artifacts" link in the upper right of a prow job (for example, see | ||
[this prow job](https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-release-master-ci-4.11-upgrade-from-stable-4.10-e2e-gcp-ovn-upgrade/1505747388038385664). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: we eventually garbage-collect these artifacts. Might be worth explaining how to get to a recent run, like going through https://prow.ci.openshift.org/?job=periodic*e2e-aws&state=success ?
|
||
* event-filter.html | ||
* included in the output of a `oc adm must-gather` | ||
* contains events from namespaces gathered by `oc adm must-gather` plus events that exist in the kube-apiserver at the time `oc adm must-gather` was run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how do "events that exist in the kube-apiserver" differ from the ones must-gather collected? Ah, because must-gather is only walking relatedResources
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that true? I'd have figured events falls into a category of things must-gather would grab globally without need of related resources.
Namespaces not listed as relatedResources for clusteroperators will be missing. | ||
* located in the prow job stored artifacts at `.../gather-must-gather/artifacts/` and contained in the must-gather.tar | ||
file in that same location | ||
* [Example](https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/logs/periodic-ci-openshift-release-master-ci-4.11-upgrade-from-stable-4.10-e2e-gcp-ovn-upgrade/1505747388038385664/artifacts/e2e-gcp-ovn-upgrade/gather-must-gather/artifacts/event-filter.html) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
before we get down to individual step content like this, it's probably worth talking about the .../{job-name}/{run-id}/artifacts/{job-slug}/{step-name}/artifacts/
structure to get artifacts from each step. Once we have established that pattern, we can say things like "in gather-must-gather assets" without having to steps to get there or linking to things that will be garbage collected a few months from now.
dev-guide/ci/events-files.md
Outdated
* Tip: wait several seconds for the html page to finish rendering so you can use the text entry boxes to search | ||
|
||
* events.json (same as `oc_cmds/events` mentioned below except as json) | ||
* generated via `oc get events --all-namespaces -o json” (see [source code](https://github.com/openshift/release/blob/f5017d5136a740a4186477b02bed70047ade200b/ci-operator/step-registry/gather/extra/gather-extra-commands.sh#L61)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: unbalanced quoting aroudn the oc ...
command here.
dev-guide/ci/events-files.md
Outdated
``` | ||
./default: | ||
total 332 | ||
-rw-rw-r-- 1 dperique dperique 339013 Dec 31 1979 events.json <-- why the ancient date? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's the Unix epoc, and is just showing the timestamp property was left unset.
Stale enhancement proposals rot after 7d of inactivity. See https://github.com/openshift/enhancements#life-cycle for details. Mark the proposal as fresh by commenting If this proposal is safe to close now please do so with /lifecycle rotten |
/remove-lifecycle stale |
Rotten enhancement proposals close after 7d of inactivity. See https://github.com/openshift/enhancements#life-cycle for details. Reopen the proposal by commenting /close |
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/reopen |
@DennisPeriquet: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
ef75efe
to
855d503
Compare
/lgtm |
/remove-lifecycle rotten |
Inactive enhancement proposals go stale after 28d of inactivity. See https://github.com/openshift/enhancements#life-cycle for details. Mark the proposal as fresh by commenting If this proposal is safe to close now please do so with /lifecycle stale |
/lifecycle frozen |
@DennisPeriquet: The In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@DennisPeriquet: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
No description provided.