Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OCPCLOUD-1475] machine: update azure-ultra-disks with data disk deletion policy #1070

Merged
merged 1 commit into from
Mar 24, 2022
Merged

[OCPCLOUD-1475] machine: update azure-ultra-disks with data disk deletion policy #1070

merged 1 commit into from
Mar 24, 2022

Conversation

damdo
Copy link
Member

@damdo damdo commented Mar 23, 2022

As a follow up to #1021 we would like to add a field to define the deletion policy for Azure Data Disks.

@lobziik
Copy link
Contributor

lobziik commented Mar 23, 2022

lgtm

@openshift-ci openshift-ci bot requested review from spadgett and squeed March 23, 2022 14:22
JoelSpeed
JoelSpeed reviewed Mar 23, 2022
View reviewed changes
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of nits, otherwise I think I'm ok with this

What are the upstream API values? Are they also Delete and Detach?

enhancements/machine-api/azure-ultra-disks.md Outdated Show resolved Hide resolved
enhancements/machine-api/azure-ultra-disks.md Outdated Show resolved Hide resolved
@JoelSpeed
Copy link
Contributor

CC @jstuever Just wanted to give you a heads up that we will need to adjust the installer configuration to allow for the user to decide how they want to retain their disks

@damdo
Copy link
Member Author

damdo commented Mar 23, 2022

What are the upstream API values? Are they also Delete and Detach?

@JoelSpeed correct, the upstream values are Delete and Detach. See https://github.com/Azure/azure-sdk-for-go/blob/bea25d2e2710632d5814b1a01a0b19ff10561ac6/services/compute/mgmt/2021-12-01/compute/models.go#L3012-L3013.

@damdo damdo force-pushed the azure-ultra-disks-deletion-policy branch 3 times, most recently from 6b6b63a to 6e67656 Compare March 23, 2022 18:23
@damdo damdo mentioned this pull request Mar 24, 2022
Merged
@damdo damdo force-pushed the azure-ultra-disks-deletion-policy branch from 6e67656 to 7039304 Compare March 24, 2022 11:12
@JoelSpeed
Copy link
Contributor

/approve
/hold until API PR is reviewed and merged

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 24, 2022

@damdo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lobziik
Copy link
Contributor

lobziik commented Mar 24, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2022
@damdo
Copy link
Member Author

damdo commented Mar 24, 2022 •
edited
Loading

API reviewed and merged.
/unhold

@damdo
Copy link
Member Author

damdo commented Mar 24, 2022

/unhold

@JoelSpeed
Copy link
Contributor

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2022
@openshift-merge-robot openshift-merge-robot merged commit a8389d0 into openshift:master Mar 24, 2022
damdo added a commit to damdo/machine-api-provider-azure that referenced this pull request Mar 24, 2022
@damdo
data disk: add deletionPolicy logic
ea478dc 
It adds logic to allow specifying the deletionPolicy field for a Data
Disk and pass it down to the provider. It's part of the changes proposed
in openshift/enhancements#1070
damdo added a commit to damdo/machine-api-provider-azure that referenced this pull request Mar 24, 2022
@damdo
data disk: add deletionPolicy logic
15161f5 
It adds logic to allow specifying the deletionPolicy field for a Data
Disk and pass it down to the provider. It's part of the changes proposed
in openshift/enhancements#1070
@damdo damdo mentioned this pull request Mar 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@spadgett spadgett Awaiting requested review from spadgett

@squeed squeed Awaiting requested review from squeed

Assignees

@lobziik lobziik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@damdo @lobziik @JoelSpeed @openshift-merge-robot