Add operator name and component labels #1078
Conversation
Signed-off-by: Shirly Radco <sradco@redhat.com>
openshift-ci
bot
added
the
needs-ok-to-test
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @sradco. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@bison @michaelgugino Please review my PR and let me know what you think. |
|
/assign @bwplotka |
| @@ -123,6 +123,10 @@ these alerts if they are not actionable. | |||
| * Runbook style documentation for resolving critical alerts is required. | |||
| These runbooks are reviewed by OpenShift SREs and currently live in the | |||
| [openshift/runbooks][2] repository. | |||
| * Operator Alerts are RECOMMENDED to include `kubernetes_operator_part_of` label | |||
| indicating the operator name the alert is related to. | |||
| * Operator Alerts are RECOMMENDED to include `kubernetes_operator_component` label | |||
There was a problem hiding this comment.
I presume we're talking about the operand? If yes, how is it different from the service or job labels?
There was a problem hiding this comment.
@simonpasquier I see that we don't set the these labels. Can you please provide me with how is it being set in other operators?
Also, I didn't see documentation for these labels. I must say that from the name it is not that clear what they exactly mean and also in most cases I see they are set to the same value.
There was a problem hiding this comment.
If you use ServiceMonitors, the service label comes from the name of the associated Kubernetes service. The same for job unless you've specified a spec.jobLabel in the ServiceMonitor.
|
Inactive enhancement proposals go stale after 28d of inactivity. See https://github.com/openshift/enhancements#life-cycle for details. Mark the proposal as fresh by commenting If this proposal is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
Stale enhancement proposals rot after 7d of inactivity. See https://github.com/openshift/enhancements#life-cycle for details. Mark the proposal as fresh by commenting If this proposal is safe to close now please do so with /lifecycle rotten |
openshift-ci
bot
added
lifecycle/rotten
|
Rotten enhancement proposals close after 7d of inactivity. See https://github.com/openshift/enhancements#life-cycle for details. Reopen the proposal by commenting /close |
|
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Added 2 recommended labels for operators alerts.
kubernetes_operator_part_of- Name of the operator the alert was fire fired from.kubernetes_operator_component- Name of the component/sub operator the alert was fire fired from.Signed-off-by: Shirly Radco sradco@redhat.com