-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add workflow description section to the template #1090
add workflow description section to the template #1090
Conversation
guidelines/enhancement_template.md
Outdated
|
||
See | ||
https://github.com/openshift/enhancements/blob/master/enhancements/workload-partitioning/management-workload-partitioning.md#high-level-end-to-end-workflow | ||
and https://github.com/openshift/enhancements/pull/1067 for more detailed examples. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll keep this PR a WIP until the second example here is merged and I can link to the published version of the doc.
2c4f9bf
to
1880c87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
q: how do these sections/changes apply if the enhancement isn't user facing?
436ad6f
to
4915dea
Compare
I would be surprised to find us making changes for which the user will neither provide input nor see any impact. Do you have an example in mind? |
4915dea
to
f645959
Compare
Rebased and removed the WIP label |
/hold We still want to wait on this to update it after the linked example in #1067 is merged. |
f645959
to
74726b1
Compare
74726b1
to
721433b
Compare
Be explicit about the expectation that user stories are written using a formula. Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
Add a new section to the enhancement template to encourage enhancement authors to explain how someone will use the feature they are describing. Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
721433b
to
2d69b08
Compare
/hold cancel |
@bparees @kikisdeliveryservice this should be ready to go now |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel Let's move along. We can tweak further if we need to. |
@dhellmann: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Add a new section to the enhancement template to encourage enhancement
authors to explain how someone will use the feature they are
describing.