Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: proposals for improving CI signal #1098

Merged
merged 3 commits into from
Apr 27, 2022

Conversation

stbenjam
Copy link
Member

@stbenjam stbenjam commented Apr 26, 2022

This is an ex post facto enhancement for TRT's initial proposals
targeting improved CI siginal: job aggregation, quick reverts, etc.
Most of this is already implemented.

This is the existing google doc converted to markdown, in
enhancement-ish format.

@stbenjam
Copy link
Member Author

/assign @deads2k

This is an ex post facto enhancement for TRT's initial proposals
targeting improved CI siginal: job aggregation, quick reverts, etc.
Most of this is already implemented.

This is the existing google doc converted to markdown, in
enhancement-ish format.
@deads2k
Copy link
Contributor

deads2k commented Apr 27, 2022

This is the doc we had before, so tagging this as our starting point.

/lgtm
/hold

holding so you can get the linter happy.

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Apr 27, 2022
@ashcrow ashcrow requested review from dgoodwin and removed request for ashcrow April 27, 2022 13:00
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 27, 2022

@stbenjam: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stbenjam
Copy link
Member Author

/hold cancel

@deads2k Needs another lgtm

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 27, 2022
@deads2k
Copy link
Contributor

deads2k commented Apr 27, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2022
@deads2k
Copy link
Contributor

deads2k commented Apr 27, 2022

huh, someone changed config in this repo eh?

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2022
@openshift-merge-robot openshift-merge-robot merged commit 5c436b4 into openshift:master Apr 27, 2022
@stbenjam stbenjam deleted the ci-signal branch April 27, 2022 15:58
@cgwalters
Copy link
Member

Thanks for converting private gdoc to public markdown!

I skimmed through this, looks overall good, just one quick comment:

  • The Linux kernel at least has had a lot of success with automated bisection; the "revert PR and see" approach is much more of a crude hammer

xref https://twitter.com/cgwalters/status/1322162509823070208 etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants