Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable webhook serving on localhost of hostnetwork #138

Closed
wants to merge 1 commit into from
Closed

Enable webhook serving on localhost of hostnetwork #138

wants to merge 1 commit into from

Conversation

tkashem
Copy link
Contributor

@tkashem tkashem commented Dec 4, 2019

We are converting api plugins into Admission Webhook server(s). This proposal
is about how we can enable kube-apiserver to communicate with admission
webhook server(s) over localhost of hostnetwork.

@tkashem
Enable webhook serving on localhost of hostnetwork
90bedbc 
We are converting api plugins into `Admission Webhook` server(s). This proposal
is about how we can enable `kube-apiserver` to communicate with admission
webhook server(s) over `localhost` of `hostnetwork`.
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 4, 2019
@tkashem tkashem mentioned this pull request Dec 4, 2019
Closed
tkashem added a commit to tkashem/cluster-resource-override-admission that referenced this pull request Dec 8, 2019
@tkashem
Deploy localhost serving admission webhook
4fdbbfb 
- Deploy localhost serving admission webhook on 'hostnetwork'.
- Implement openshift/enhancements#138
@tkashem tkashem mentioned this pull request Dec 8, 2019
Merged
tkashem added a commit to tkashem/cluster-resource-override-admission that referenced this pull request Dec 8, 2019
@tkashem
Deploy localhost serving admission webhook
e12d9b5 
- Deploy localhost serving admission webhook on 'hostnetwork'.
- Implement openshift/enhancements#138
tkashem added a commit to tkashem/cluster-resource-override-admission that referenced this pull request Dec 8, 2019
@tkashem
Deploy localhost serving admission webhook
0d1861b 
- Deploy localhost serving admission webhook on 'hostnetwork'.
- Implement openshift/enhancements#138
deads2k
deads2k reviewed Dec 11, 2019
View reviewed changes
enhancements/autoscaling/webhook-serving-on-localhost-of-hostnetwork.md
---

# Admission Webhook Serving on localhost of hostnetwork
We are converting api plugins into `Admission Webhook` server(s). This proposal is about how we can enable `kube-apiserver` to communicate with admission webhook server(s) over `localhost` of `hostnetwork`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

admission plugins

@deads2k
Copy link
Contributor

deads2k commented Dec 11, 2019

See if you can bring #13 up to date and add this as the mechanism you use for communication.

@tkashem
Copy link
Contributor Author

tkashem commented Dec 11, 2019

See if you can bring #13 up to date and add this as the mechanism you use for communication.

Sounds good!

@openshift-ci-robot
Copy link

@tkashem: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tkashem
To complete the pull request process, please assign sjenning
You can assign the PR to them by writing /assign @sjenning in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tkashem
Copy link
Contributor Author

tkashem commented Jan 7, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 7, 2020
@russellb
Copy link
Member

@tkashem Hi, you held this PR back in January. Can you take a look and see if it's still relevant? Was it implemented and should just be merged? Or is it no longer relevant and should be closed?

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 15, 2020
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 15, 2020
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci-robot
Copy link

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k deads2k left review comments

@spadgett spadgett Awaiting requested review from spadgett

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tkashem @deads2k @openshift-ci-robot @russellb @openshift-bot