Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openstack: Add Baremetal Compute Nodes RFE #146

Conversation

pierreprinetti
Copy link
Member

No description provided.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 10, 2019
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 10, 2019
@EricArrakis
Copy link

Have you had anyone from the BM team review this? Please also have OSP and OCP QE review too.

@pierreprinetti pierreprinetti force-pushed the openstack-baremetal-compute branch from 0d81f08 to c9522d3 Compare December 11, 2019 11:29
Copy link
Contributor

@tomassedovic tomassedovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't get to read and reply more thoroughly yet. Put up what thoughts I had, going to have another look tomorrow.

pierreprinetti added a commit to pierreprinetti/openshift-enhancements that referenced this pull request Dec 17, 2019
Copy link
Contributor

@tomassedovic tomassedovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments. I'll try to flesh out some of the missing sections now.

@tomassedovic
Copy link
Contributor

@pierreprinetti I've added some text into the Alternatives section here: pierreprinetti#2

Going to pick another TBD block soon.

pierreprinetti added a commit to pierreprinetti/openshift-enhancements that referenced this pull request Dec 18, 2019
pierreprinetti added a commit to pierreprinetti/openshift-enhancements that referenced this pull request Dec 18, 2019
@tomassedovic
Copy link
Contributor

Thank you so much for your feedback @juliakreger and @cybertron! I've updated some bits and will do more tomorrow, your comments have been really helpful.

And I appreciate the heads-up regarding folks being away until the end of 2019. There is no rush with this for now, we'll flesh this out more and then ask for another round of feedback in January.

@pierreprinetti pierreprinetti force-pushed the openstack-baremetal-compute branch from 905209a to cc04219 Compare April 2, 2020 09:21
@pierreprinetti pierreprinetti marked this pull request as ready for review April 2, 2020 09:22
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 2, 2020
@pierreprinetti pierreprinetti force-pushed the openstack-baremetal-compute branch from cc04219 to 78fbd8a Compare April 7, 2020 12:08
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2020
@adduarte
Copy link

/lgtm

@pierreprinetti
Copy link
Member Author

/assign @abhinavdahiya

@pierreprinetti pierreprinetti force-pushed the openstack-baremetal-compute branch from 5705137 to 03e5d7f Compare September 23, 2020 10:39
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2020
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@pierreprinetti pierreprinetti force-pushed the openstack-baremetal-compute branch from 03e5d7f to acb2a0e Compare October 23, 2020 09:05
@pierreprinetti
Copy link
Member Author

I have removed the case "3" where BM workers were added as a day2 operation, on a separate subnet. We are implementing "separate subnets" as a 4.7 feature, that will apply to both VMs and BMs.

@mandre @adduarte @abhinavdahiya PTAL

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 23, 2021
@pierreprinetti
Copy link
Member Author

/remove-lifecycle stale
/cc @mandre @adduarte

PTAL

@openshift-ci-robot openshift-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 27, 2021
@pierreprinetti pierreprinetti force-pushed the openstack-baremetal-compute branch from acb2a0e to e74e0ac Compare February 23, 2021 11:27
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign abhinavdahiya after the PR has been reviewed.
You can assign the PR to them by writing /assign @abhinavdahiya in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Co-authored-by: Tomas Sedovic <tomas@sedovic.cz>
@pierreprinetti pierreprinetti force-pushed the openstack-baremetal-compute branch from e74e0ac to 7337b65 Compare February 23, 2021 12:12
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 25, 2021
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 24, 2021
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Jul 24, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2021

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.