-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openstack: Add Baremetal Compute Nodes RFE #146
openstack: Add Baremetal Compute Nodes RFE #146
Conversation
Have you had anyone from the BM team review this? Please also have OSP and OCP QE review too. |
0d81f08
to
c9522d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I didn't get to read and reply more thoroughly yet. Put up what thoughts I had, going to have another look tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more comments. I'll try to flesh out some of the missing sections now.
@pierreprinetti I've added some text into the Alternatives section here: pierreprinetti#2 Going to pick another TBD block soon. |
Thank you so much for your feedback @juliakreger and @cybertron! I've updated some bits and will do more tomorrow, your comments have been really helpful. And I appreciate the heads-up regarding folks being away until the end of 2019. There is no rush with this for now, we'll flesh this out more and then ask for another round of feedback in January. |
905209a
to
cc04219
Compare
cc04219
to
78fbd8a
Compare
/lgtm |
/assign @abhinavdahiya |
5705137
to
03e5d7f
Compare
New changes are detected. LGTM label has been removed. |
03e5d7f
to
acb2a0e
Compare
I have removed the case "3" where BM workers were added as a day2 operation, on a separate subnet. We are implementing "separate subnets" as a 4.7 feature, that will apply to both VMs and BMs. |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
acb2a0e
to
e74e0ac
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Co-authored-by: Tomas Sedovic <tomas@sedovic.cz>
e74e0ac
to
7337b65
Compare
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.