WIP: Add OKD featureset enhancement #1899
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
jatinsu
force-pushed
the
OKD-featuregates
branch
from
9a16308 to
a81a730
Compare
jatinsu
force-pushed
the
OKD-featuregates
branch
2 times, most recently
from
075812e to
a0218a1
Compare
jatinsu
force-pushed
the
OKD-featuregates
branch
from
a0218a1 to
8808148
Compare
enhancements/okd/okd-featureset.md
Outdated
| - Resource consumption impact should be minimal as the feature set itself only controls which features are enabled, not the features themselves | ||
| - Individual features enabled by the OKD feature set may have their own resource implications | ||
|
|
||
| **MicroShift:** |
There was a problem hiding this comment.
OKD featureset shouldn't affect microshift right?
There was a problem hiding this comment.
i don't think so, would be good to check with someone in the Microshift team
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Prashanth684
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
enhancements/okd/okd-featureset.md
Outdated
| - Resource consumption impact should be minimal as the feature set itself only controls which features are enabled, not the features themselves | ||
| - Individual features enabled by the OKD feature set may have their own resource implications | ||
|
|
||
| **MicroShift:** |
There was a problem hiding this comment.
i don't think so, would be good to check with someone in the Microshift team
jatinsu
force-pushed
the
OKD-featuregates
branch
from
e35a6c7 to
5f9509a
Compare
jatinsu
force-pushed
the
OKD-featuregates
branch
from
52ec4b8 to
ee8db1a
Compare
jatinsu
force-pushed
the
OKD-featuregates
branch
from
0f2881a to
79df581
Compare
- Condensed enhancement to make it more concise - reworded some features and addressed comments - made points into paragraphs and fixed long lines - Removed version.IsOKD() and explained the logic
jatinsu
force-pushed
the
OKD-featuregates
branch
from
79df581 to
f9249fc
Compare
|
@jatinsu: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
This PR is to create an enhancement for the OKD featureset.
For more context: openshift/api#2451