Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancements/update/update-blocker-lifecycle: Propose a new enhancement #475

Merged

Conversation

wking
Copy link
Member

@wking wking commented Sep 11, 2020

No description provided.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 20, 2020
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 19, 2021
@sdodson
Copy link
Member

sdodson commented Jan 19, 2021

/remove-lifecycle stale
I know @wking references this often so I'll try to make an effort to push this forward.

@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci-robot
Copy link

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking
Copy link
Member Author

wking commented Mar 30, 2021

We got very close to missing the importance of a vSphere hostname bug before 4.7.z -> 4.7.4 edges landed in stable-4.7: openshift/cincinnati-graph-data#731. Reopening to see if we can tighten down our process for identification and triage.

/reopen

@openshift-ci-robot
Copy link

@wking: Reopened this PR.

In response to this:

We got very close to missing the importance of a vSphere hostname bug before 4.7.z -> 4.7.4 edges landed in stable-4.7: openshift/cincinnati-graph-data#728. Reopening to see if we can tighten down our process for identification and triage.

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign sttts after the PR has been reviewed.
You can assign the PR to them by writing /assign @sttts in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wking wking force-pushed the update-blocker-lifecycle branch from 064b4f9 to 07046e6 Compare March 30, 2021 19:30
@wking
Copy link
Member Author

wking commented Mar 30, 2021

I've pushed 064b4f9 -> 07046e6 to rebase on master, accept the "keep UpgradeBlocker" approach, and add Bugzilla queries for each of the queues.

@wking wking force-pushed the update-blocker-lifecycle branch from 07046e6 to 8af5330 Compare March 30, 2021 19:35
@wking
Copy link
Member Author

wking commented Mar 30, 2021

/lifecycle frozen

@openshift-ci-robot
Copy link

@wking: The lifecycle/frozen label cannot be applied to Pull Requests.

In response to this:

/lifecycle frozen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

@sferich888 sferich888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this enhancement / workflow change (not sure if this proposal belongs in the enhancements vs an issue on the OSO/BAT team Jira board) may help one team better find issues I don't think this goes far enough in addressing the underlying/system issues we have with product quality that lead us to need the 'blocked' edges mechanism.


# Update-blocker Lifecycle

We occasionally have bugs which impact update success or the stability of the target release.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
We occasionally have bugs which impact update success or the stability of the target release.
We regularly have bugs which impact update success or the stability of the target release.

# Update-blocker Lifecycle

We occasionally have bugs which impact update success or the stability of the target release.
When that happens, we protect users by [removing the impacted updates from our update recommendations][graph-data-block].

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we over use this mechanism, and the rational / reason for over using it is because we can't tailor the updates to specific accounts or classes of accounts.

IE: https://issues.redhat.com/browse/OTA-267 & https://issues.redhat.com/browse/OTA-191


- [x] Enhancement is `implementable`
- [x] Design details are appropriately documented from clear requirements
- [ ] Test plan is defined

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xltian don't we define a test plan to proactively find/identify bugs with each release?

If we are already doing this; then what is missing with the current process that is leading to so many issues being found / requiring us to use a blocked edge?

- [ ] Graduation criteria for dev preview, tech preview, GA
- [ ] User-facing documentation is created in [openshift-docs](https://github.com/openshift/openshift-docs/)

## Summary

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing in the summary of this proposal addresses the core/root issue (the underlying product quality issue that is leading to the us having to 'block' edges in the first place.

All this proposal does; is enhance our ability for individuals to 'signal' things that 'might' be a possible issue; and for decision makers to 'find' those issues in the vast sea of issues that we face day to day.

@LalatenduMohanty
Copy link
Member

/lifecycle frozen

@openshift-ci-robot
Copy link

@LalatenduMohanty: The lifecycle/frozen label cannot be applied to Pull Requests.

In response to this:

/lifecycle frozen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this May 30, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 30, 2021

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LalatenduMohanty
Copy link
Member

/reopen

@openshift-ci openshift-ci bot reopened this Jun 10, 2021
@wking wking force-pushed the update-blocker-lifecycle branch from 39fc1e8 to 5f22c25 Compare June 17, 2021 22:49
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 18, 2021

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot closed this Jul 18, 2021
@LalatenduMohanty
Copy link
Member

/reopen

@openshift-ci openshift-ci bot reopened this Aug 3, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 3, 2021

@LalatenduMohanty: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 2, 2021

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot closed this Sep 2, 2021
@LalatenduMohanty
Copy link
Member

/reopen

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 5, 2021

@LalatenduMohanty: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot reopened this Nov 5, 2021
Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@LalatenduMohanty
Copy link
Member

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 5, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LalatenduMohanty

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2021
wking added 2 commits November 5, 2021 13:58
Generated with:

  $ (cd enhancements/update/update-blocker-lifecycle; dot -Tsvg flow.dot >flow.svg)

using:

  $ dot -V
  dot - graphviz version 2.47.1 (0)
@wking wking force-pushed the update-blocker-lifecycle branch from 5f22c25 to 504432a Compare November 5, 2021 21:01
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2021
@wking
Copy link
Member Author

wking commented Nov 5, 2021

Rebased around #933 and added not-applicable stubs for the new sections in 5f22c25 -> 504432a.

@LalatenduMohanty
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2021
@openshift-merge-robot openshift-merge-robot merged commit 2911c46 into openshift:master Nov 5, 2021
@wking wking deleted the update-blocker-lifecycle branch November 5, 2021 21:11
Write tooling that automatically:

* Removes the new labels if any labels from later in the process are set.
* Adds `Upgrades` and `UpgradeBlocker` to any bugs with any of the new labels.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wking have you brought this use case to the jira migration team to make sure they are thinking about how to support things like this when we go to jira?


No drawbacks.

## Alternatives
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was there a reason we couldn't use flags (UpgradeBlocker?, UpgradeBlocker+, UpgradeBlocker-) instead of keywords?

UpgradeBlocker? would equate to "impact statement requested"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(flags would be more consistent with our release blocking mechanism)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants