Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register baremetal provisioning ports #556

Merged
merged 2 commits into from
Dec 3, 2020

Conversation

zaneb
Copy link
Member

@zaneb zaneb commented Dec 2, 2020

These two ports are used on control plane nodes to cache files that must
be served as part of provisioning baremetal hosts via the
baremetal-operator.

These two ports are used on control plane nodes to cache files that must
be served as part of provisioning baremetal hosts via the
baremetal-operator.
@zaneb
Copy link
Member Author

zaneb commented Dec 2, 2020

/cc @russellb

@dhellmann
Copy link
Contributor

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2020
@stbenjam
Copy link
Member

stbenjam commented Dec 2, 2020

Should we register the port for Ironic too?

@zaneb
Copy link
Member Author

zaneb commented Dec 3, 2020

Yeah, and inspector, conductor, mariadb...

@stbenjam
Copy link
Member

stbenjam commented Dec 3, 2020

Thanks, sorry a couple more things.

  • Can we mention for the ironic services that they only listen on one control plane host, only on baremetal?

Ports are assumed to be used on all nodes in all clusters unless otherwise specified.

  • The doc says we need to declare the ports on the pod spec, which we aren't doing. Is that something we need to do in the CBO?

- declare that port in their `Pod.Spec`

@zaneb
Copy link
Member Author

zaneb commented Dec 3, 2020

Thanks, sorry a couple more things.

* Can we mention for the ironic services that they only listen on one control plane host, only on baremetal?

I mentioned that it's control-plane only; I think that's sufficient. You don't know which node it's going to be on, and it can move, so it's not like you can go ahead and reuse those ports on other hosts. For the purposes of this document these services own these ports on the control plane.

I agree that it might not be obvious to everyone that stuff that mentions baremetal only runs when the platform is baremetal IPI. Not sure how to fit that in the notes column without writing an essay :D

* The doc says we need to declare the ports on the pod spec, which we aren't doing. Is that something we need to do in the CBO?

Yes. I added it to my PR already.

@stbenjam
Copy link
Member

stbenjam commented Dec 3, 2020

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, stbenjam, zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2020
@openshift-merge-robot openshift-merge-robot merged commit 5f2529a into openshift:master Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants