Added proposal for remediation history

[slintes]

We propose to track a limited history of remediations and showing it in the UI in order to allow admins to detect recurring node problems easier.

/cc @beekhof @JoelSpeed @michaelgugino @enxebre

[slintes]

@jewzaam @JoelSpeed Thanks for your review! Please check my comments / improvements.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign spadgett after the PR has been reviewed.
You can assign the PR to them by writing /assign @spadgett in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[slintes]

Before we go on discussing names of timestamps on outdated code snippets... is this fine for everyone?

	// the time when the unhealthy condition was detected
	Detected *metav1.Time `json:"detected"`

	// the time when remediation started, will be around "detected" plus the "timeout" configured on the MHC
	Started *metav1.Time `json:"started,omitempty"`

	// the time when the node is remediated and in a safe state, so that workloads can be rescheduled.
	Remediated *metav1.Time `json:"remediated,omitempty"`

[beekhof]

@JoelSpeed anything holding this back from being merged?

[JoelSpeed]

As I understand it, a machine will get detected, the remediation event will be added, that event will then be updated as time progresses. What happens if that remediation event never actually causes a remediation, does the status then look like we lost track of it?

Do we need to have a third Type that is called recovered and then if we detect a machine that we thought would go unhealthy, mark the event as recovered?
(If we go down this avenue, how does this work when nodes are starting, since they appear unhealthy at first?)

Has there been any discussion with the upstream community about this type of enhancement, would be good to have this feature upstreamed as well

[slintes]

Renamed Remediation to RemediationEvent and further clarified values of the Type field (machineDeletion or external or aborted now)

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[slintes]

/remove-lifecycle rotten

[slintes]

/remove-lifecycle rotten

[openshift-bot]

Inactive enhancement proposals go stale after 28d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Mark the proposal as fresh by commenting /remove-lifecycle stale.
Stale proposals rot after an additional 30d of inactivity and eventually close.
Exclude this proposal from closing by commenting /lifecycle frozen.

If this proposal is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale enhancement proposals rot after 7d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Mark the proposal as fresh by commenting /remove-lifecycle rotten.
Rotten proposals close after an additional 7d of inactivity.
Exclude this proposal from closing by commenting /lifecycle frozen.

If this proposal is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[openshift-bot]

Rotten enhancement proposals close after 7d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Reopen the proposal by commenting /reopen.
Mark the proposal as fresh by commenting /remove-lifecycle rotten.
Exclude this proposal from closing again by commenting /lifecycle frozen.

/close

[openshift-ci]

@openshift-bot: Closed this PR.

In response to this:

Rotten enhancement proposals close after 7d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Reopen the proposal by commenting /reopen.
Mark the proposal as fresh by commenting /remove-lifecycle rotten.
Exclude this proposal from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.