-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1908145: Add workloads localhost ports for recovery-controllers #569
Conversation
@damemi: This pull request references Bugzilla bug 1908145, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -121,10 +121,12 @@ Ports are assumed to be used on all nodes in all clusters unless otherwise speci | |||
|-------|-----------|-------------|-------|-------| | |||
| 4180 | machine-config-daemon oauth-proxy | node || | |||
| 8797 | machine-config-daemon | node |4.0| metrics | | |||
| 9443 | kube-controller-manager | workloads || recovery-controller| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be in near the KAS https://github.com/openshift/enhancements/pull/569/files#diff-622c5939f9f7beba1c96c9d2fd6e5b2a8c457f9be706a473da0cf7db9f34a51eR77 as it also listens on 0.0.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you clarify what you mean? I don't see KAS listed for 0.0.0.0 in this doc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@damemi: All pull requests linked via external trackers have merged: Bugzilla bug 1908145 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This adds the updated port, as recommended in https://bugzilla.redhat.com/show_bug.cgi?id=1908145#c1 and changed in openshift/cluster-kube-scheduler-operator#311