add SR-IOV GA proposal

[zshi-redhat]

No description provided.

[stevekuznetsov]

/uncc

[squeed]

This is going to be hard, because Multus has to ask for runtimeConfiguration via its CNI configuration file, which is static. We'll probably need to think of a way for NetworkAttachmentDefinitions to ask for CNI capabilites.

cc @dcbw

[s1061123]

We use network selection element in Pod annotation to describe IP/Mac, not in network attachment definition.
In K8s NPWG, we're already finalize about it and implemented in multus.

See the following Spec/PR for the detail:
Spec proposal: https://docs.google.com/document/d/1j9kSTIIKydjqGiYd8Ni9Tej7gv1sxf9VcWeRYXFe5ko/edit
PR: k8snetworkplumbingwg/multus-cni#387

[squeed]

So, the proposal is just about passing the IP runtimeConfig? That makes more sense.

[s1061123]

Right.

[squeed]

This just sounds like https://github.com/nokia/danm

[s1061123]

@squeed so you think that we should NOT do that? If so, could you please let us know why?

[zshi-redhat]

@squeed Is it because that with default route overwrite, Multus is doing too much other than just calling delegated plugins which sounds like a thick plugin such as danm?

[s1061123]

@squeed btw, we're going to use https://github.com/redhat-nfvpe/cni-route-override to override CNI route (except default route). For default route, we are proposing 'gateway' feature in NPWG.

If you think that multus includes route manipulation inside it and getting thick plugin, that is not correct, actually. We're still designing as minimum as possible.

[squeed]

Okay, that should work as well. Could you provide some example configuration? It's important that we design something that will work with CNI CHECK.

[s1061123]

Here is the example config:
https://github.com/redhat-nfvpe/cni-route-override#example-configuration

[zshi-redhat]

@squeed I will add a default route overwrite example soon in a separate PR, sth like this:

kind: Pod
metadata:
  name: my-pod
  namespace: my-namespace
  annotations:
    k8s.v1.cni.cncf.io/networks: |
      [
        { "name":"net-a" },
        {
          "name":"net-b",
          "default-route": ["10.0.0.1"]
        }
      ]

[zshi-redhat]

also paste the link for default route overwirte proposal: https://docs.google.com/document/d/1pqbWYtFdEYyXd1cXuyvq_J5SRnhiXCRptXho63gI4A8/edit

[fepan]

This should be part of GA now that we have 1.16 in 4.3.

[zshi-redhat]

fixed

[fepan]

Security and QoS flags are not a requirements for GA.

[zshi-redhat]

Removed

[fepan]

Add NUMA support here.

[zshi-redhat]

added

[fepan]

/lgtm

[squeed]

/approve

As discussed elsewhere, I'd like to see a follow-up PR that outlines how routes will be configured. But that isn't blocking.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fepan, squeed, zshi-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [squeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment