Add Customize Add Page proposal #669
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
christoph-jerolimov
force-pushed
the
customize-add-page
branch
2 times, most recently
from
b21f1d5
to
6ea9595
Compare
christoph-jerolimov
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/uncc imcleod jcantrill |
openshift-ci-robot
requested review from
christianvogt,
jhadvig and
spadgett
and removed request for
imcleod and
jcantrill
christoph-jerolimov
force-pushed
the
customize-add-page
branch
from
6ea9595
to
cb0f2b3
Compare
|
@christianvogt See update above. Hope its fine to keep these questions with the answers in the doc. Anything else? |
|
@christianvogt Pushed a commit with changes based on your recommendation. I hope that I don't add to many new issues. Wdyt? |
christoph-jerolimov
force-pushed
the
customize-add-page
branch
from
b41200a
to
8365456
Compare
|
@christianvogt Take all your last typo fixes 1:1 and rebased this changes to one commit. |
|
/lgtm |
|
|
||
| The admin needs to know the current available actions to hide them. We don't want to provide the defaults in the CR so that we can change these defaults later without migrating the customer data. | ||
|
|
||
| To provide the default values close to the editor, the console will provide a code snippets in the sidebar of the YAML editor when editing the `Console` operator config. The snippets should include the IDs of all actions. |
There was a problem hiding this comment.
We probably need more than a snippet to document these, particularly since a lot of admins use the CLI. Have we given thought about where else we can publish these? Maybe in the console customization topic in the OpenShift docs and the API docs for the property.
Have we considered a simple UI for admins to update them (even if not in 4.8)? Maybe a modal similar to what we have for table column customization.
There was a problem hiding this comment.
A UI is being considered in future however plans yet in 4.8 or 4.9. This may fall under the umbrella of the same mechanism that will serve customized dashboards.
I agree that we can work with docs to provide guidance on customizing this and other configurations similar to it.
There was a problem hiding this comment.
@spadgett @christianvogt Should we discuss this in slack and open a ticket in the epics for this? I also expect that we should do this for all 4 (!) customization options we will have in 4.8.
- dev catalog categories
- available cluster roles to assign on the project page (project access)
- disable actions on the add page
- disable quick starts
There was a problem hiding this comment.
I think we can move forward with this enhancement and provide docs.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Issues:
Epic: https://issues.redhat.com/browse/ODC-5013
High level design: https://issues.redhat.com/browse/DTUX-849 on Google Docs
Final design: https://issues.redhat.com/browse/PD-818 on Google Docs
Story: https://issues.redhat.com/browse/ODC-5412
Rendered preview: https://github.com/jerolimov/openshift-enhancements/blob/customize-add-page/enhancements/console/customize-add-page.md