Add Enhancement for Installing to Alibaba Cloud #707
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
needs-ok-to-test
|
Hi @lemondlut. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
openshift-ci-robot
added
ok-to-test
openshift-ci
bot
requested review from
aravindhp,
derekwaynecarr,
eparis,
JoelSpeed and
staebler
|
@Lyt99 @lemondlut @bd233 Can we please provide feedback to @dhellmann's comments? Let's focus on expanding on these details and getting this enhancement closed out. |
| 2. Installer provides few but useful and comprehensive customizations through the install-config.yaml file. | ||
| 3. RHCOS images are built and published to Alibaba as part of the images pipeline process. | ||
|
|
||
| - Red Hat builds the RHCOS images from their build pipeline. |
There was a problem hiding this comment.
Is this list on lines 43-49 a set of goals, or part of the proposed solution?
There was a problem hiding this comment.
@dhellmann I think this is part of the proposed solution. The steps are planned and required to enable Alibaba as a platform. These steps will be very similar to AWS and mimics our existing build pipeline and tools.
| - Category: ESSD | ||
| - InstanceType: g6a.xlarge | ||
|
|
||
| - SLB: |
There was a problem hiding this comment.
@lemondlut Thanks for the updates.
I see the high level details pertaining to account creation, installer augmentation, as well as CI creation. I believe that is what is on the table for delivery.
|
/lgtm |
|
@lemondlut Let's squash these commits into a single commit and then we will merge. Thanks |
|
|
@lemondlut Excellent job on the squash! /lgtm |
|
@rvanderp3 Please review when you have a minute. The commits have been squashed. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kwoodson, rvanderp3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Create an enhancement for installing and supporting OpenShift on Alibaba Cloud.