Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New enhancment proposal: forward-to-Loki #710

Merged
merged 1 commit into from
Apr 15, 2021
Merged

New enhancment proposal: forward-to-Loki #710

merged 1 commit into from
Apr 15, 2021

Conversation

alanconway
Copy link
Contributor

Proposal to add loki forwarding to the ClusterLogForwarder.
First draft, see Open Questions and TODO markers.

/assign @jcantrill
/cc @periklis

@syedriko
Copy link

@alanconway Could you fix the spelling of the title and the syntax so there's no red background?

@alanconway
Copy link
Contributor Author

@periklis see #710 (comment) for discussion on pod name. I'm still undecided, and I'm hoping you can help me decide.

@alanconway
Copy link
Contributor Author

Updated to include pod name by default, remove container name (see text for explanation) and allow the user to replace the default label set instead of just add to it.
Sombody gimme an LGTM :)

@alanconway
Copy link
Contributor Author

/hold
/approve

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alanconway

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2021
@alanconway alanconway mentioned this pull request Apr 8, 2021
Merged
@alanconway alanconway force-pushed the forward-to-loki branch 3 times, most recently from f7c621e to 5ab038d Compare April 12, 2021 18:55
@alanconway
New enhancment proposal: forward-to-Loki
66a341c 
Proposal to add loki forwarding to the ClusterLogForwarder.
@alanconway
Copy link
Contributor Author

/unhold

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2021
@periklis
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2021
@openshift-merge-robot openshift-merge-robot merged commit a0f9019 into openshift:master Apr 15, 2021
@alanconway alanconway deleted the forward-to-loki branch April 20, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Red-GV Red-GV Red-GV left review comments

@syedriko syedriko syedriko left review comments

@eranra eranra eranra left review comments

@cyriltovena cyriltovena cyriltovena left review comments

@periklis periklis periklis left review comments

Assignees

@periklis periklis

@jcantrill jcantrill

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@alanconway @syedriko @openshift-ci-robot @periklis @cyriltovena @eranra @Red-GV @jcantrill @openshift-merge-robot