Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workload-partitioning: reorganize #759

Merged
merged 1 commit into from
Jun 2, 2021
Merged

workload-partitioning: reorganize #759

merged 1 commit into from
Jun 2, 2021

Conversation

dhellmann
Copy link
Contributor

We are going to be writing a few more enhancements related to the
workload partitioning feature, so create a subdirectory and move the
existing design doc there.

/cc @mrunalp @browsell

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from dhellmann after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dhellmann
Copy link
Contributor Author

/priority important-soon

@openshift-ci-robot openshift-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Apr 27, 2021
dhellmann added a commit to dhellmann/openshift-enhancements that referenced this pull request Apr 27, 2021
@dhellmann
tools: cope with PRs with 1 renamed file
c82f119 
The show-pr command panicked when run against openshift#759, which has only a
renamed file without any modifications.

Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
@dhellmann dhellmann mentioned this pull request Apr 27, 2021
Merged
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 3, 2021
@dhellmann
workload-partitioning: reorganize
043acde 
We are going to be writing a few more enhancements related to the
workload partitioning feature, so create a subdirectory and move the
existing design doc there.

Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
@dhellmann dhellmann force-pushed the workload-partitioning-reorg branch from 130a9d9 to 043acde Compare May 3, 2021 12:33
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 3, 2021
mrunalp
mrunalp approved these changes Jun 2, 2021
View reviewed changes
Copy link
Member

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 2, 2021
@openshift-merge-robot openshift-merge-robot merged commit 4833ab9 into openshift:master Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp approved these changes

@browsell browsell Awaiting requested review from browsell

Assignees

@mrunalp mrunalp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhellmann @openshift-ci-robot @mrunalp @openshift-merge-robot