Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify and clarify JSON forwarding proposal, better examples. #780

Merged
merged 1 commit into from
Jun 11, 2021
Merged

Simplify and clarify JSON forwarding proposal, better examples. #780

merged 1 commit into from
Jun 11, 2021

Conversation

alanconway
Copy link
Contributor

No description provided.

This was referenced May 12, 2021
Merged
Merged
@alanconway
Copy link
Contributor Author

/approve
/cc @christianvogt

@openshift-ci openshift-ci bot requested a review from christianvogt May 13, 2021 12:27
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alanconway

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2021
@christianvogt
Copy link
Contributor

@alanconway, I think you wanted the other Christian :) @sichvoge

@alanconway
Copy link
Contributor Author

@sichvoge can you do a final read and /lgtm if everything looks good? Sorry I pulled in the wrong Christaian earlier.
/cc @sichvoge

@openshift-ci openshift-ci bot requested a review from sichvoge May 17, 2021 20:12
@sichvoge
Copy link

So is it indexKey and indexName or structuredIndexKey and structuredIndexName?

@vimalk78 vimalk78 mentioned this pull request May 25, 2021
Merged
@alanconway alanconway force-pushed the forward-json-clarify branch 3 times, most recently from 74b98a8 to 4e28b57 Compare May 26, 2021 14:31
@ewolinetz
Copy link
Contributor

markdown needs to be fixed but lgtm otherwise

@alanconway
Copy link
Contributor Author

alanconway commented May 31, 2021 •
edited
Loading

@ewolinetz fixed the markdown, can I have an /lgtm please? @jcantrill @sichvoge anyone?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 7, 2021

@alanconway: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sichvoge
Copy link

sichvoge commented Jun 8, 2021

LGTM

@sichvoge
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2021
@openshift-merge-robot openshift-merge-robot merged commit 0f5c62f into openshift:master Jun 11, 2021
@alanconway alanconway deleted the forward-json-clarify branch September 14, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anpingli anpingli anpingli left review comments

@jcantrill jcantrill jcantrill left review comments

@ewolinetz ewolinetz ewolinetz left review comments

@christianvogt christianvogt Awaiting requested review from christianvogt

@sichvoge sichvoge Awaiting requested review from sichvoge

Assignees

@sichvoge sichvoge

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@alanconway @christianvogt @sichvoge @ewolinetz @jcantrill @anpingli @openshift-merge-robot