-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1904507: Update vsphere-problem-detector with current implementation #790
Bug 1904507: Update vsphere-problem-detector with current implementation #790
Conversation
@jsafrane: This pull request references Bugzilla bug 1904507, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (wduan@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Syncing current implementation into the enhancement. We did not implement some metrics, because we no longer think they're useful. Adding Datastore Type to be able to tell what our customers use, because NFS may be deprecated.
58f60ce
to
dd83e27
Compare
@jsafrane: This pull request references Bugzilla bug 1904507, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (wduan@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knobunc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jsafrane: All pull requests linked via external trackers have merged: Bugzilla bug 1904507 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Syncing current implementation into the enhancement. We did not implement some metrics, because we no longer think they're useful.
Adding Datastore Type to be able to tell what our customers use, because NFS may be deprecated.
Updating some chapter headings to make
markdownlint
happy.cc @gnufied @jcpowermac