-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CONVENTIONS.md: add runlevel documentation #805
CONVENTIONS.md: add runlevel documentation #805
Conversation
This commit adds what runlevels are, some reasons why they have been historically required and the reasons why they are no longer needed. Signed-off-by: mcoops <cooper.d.mark@gmail.com>
Hi @mcoops. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@mcoops, if you make your membership in the openshift org on Github public the bot will be able to see that it's OK to test your PRs. /ok-to-test |
Signed-off-by: mcoops <cooper.d.mark@gmail.com>
@dhellmann is there anything else I should be doing to help this PR along? |
@mcoops the text you've written is clear to me, but I'm not a subject matter expert so I don't think it's a good idea for me to approve it. Let me see if I can help chase down a reviewer for you. |
The text is accurate. Thanks! /lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Brief summary on what
runlevels
are, some reasons why they have been historically required and why the defining of the runlevel label is no longer needed.Based on documentation worked on with @deads2k - with the help greatly appreciated.
Also addresses #303