Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONVENTIONS.md: add runlevel documentation #805

Merged
merged 2 commits into from
Aug 26, 2021
Merged

CONVENTIONS.md: add runlevel documentation #805

merged 2 commits into from
Aug 26, 2021

Conversation

mcoops
Copy link
Contributor

@mcoops mcoops commented Jun 8, 2021

Brief summary on what runlevels are, some reasons why they have been historically required and why the defining of the runlevel label is no longer needed.

Based on documentation worked on with @deads2k - with the help greatly appreciated.

Also addresses #303

This commit adds what runlevels are, some reasons why they have been
historically required and the reasons why they are no longer needed.

Signed-off-by: mcoops <cooper.d.mark@gmail.com>
@openshift-ci openshift-ci bot requested review from celebdor and dustymabe June 8, 2021 15:54
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 8, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2021

Hi @mcoops. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dhellmann
Copy link
Contributor

@mcoops, if you make your membership in the openshift org on Github public the bot will be able to see that it's OK to test your PRs.

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 14, 2021
Signed-off-by: mcoops <cooper.d.mark@gmail.com>
@mcoops
Copy link
Contributor Author

mcoops commented Aug 26, 2021

@dhellmann is there anything else I should be doing to help this PR along?

@dhellmann
Copy link
Contributor

@mcoops the text you've written is clear to me, but I'm not a subject matter expert so I don't think it's a good idea for me to approve it. Let me see if I can help chase down a reviewer for you.

@deads2k
Copy link
Contributor

deads2k commented Aug 26, 2021

The text is accurate. Thanks!

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2021
@dhellmann
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 26, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2021
@openshift-merge-robot openshift-merge-robot merged commit f6da5f4 into openshift:master Aug 26, 2021
@mcoops mcoops deleted the add_runlevel_doco branch August 27, 2021 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants